Message ID | 20240116075636.6121-4-ville.syrjala@linux.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/i915: (stolen) memory region related fixes | expand |
On 1/16/2024 8:56 AM, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Now that intel_memory_regions_hw_probe() prints out each and every > memory region there's no reason to have ad-hoc debugs to do similar > things elsewhere. > > Cc: Paz Zcharya <pazz@chromium.org> > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ---- > drivers/gpu/drm/i915/gt/intel_region_lmem.c | 3 --- > 2 files changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > index d2440c793f84..ee237043c302 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > @@ -828,7 +828,6 @@ static const struct intel_memory_region_ops i915_region_stolen_smem_ops = { > > static int init_stolen_lmem(struct intel_memory_region *mem) > { > - struct drm_i915_private *i915 = mem->i915; > int err; > > if (GEM_WARN_ON(resource_size(&mem->region) == 0)) > @@ -844,9 +843,6 @@ static int init_stolen_lmem(struct intel_memory_region *mem) > !io_mapping_init_wc(&mem->iomap, mem->io.start, resource_size(&mem->io))) > goto err_cleanup; > > - drm_dbg(&i915->drm, "Stolen Local DSM: %pR\n", &mem->region); > - drm_dbg(&i915->drm, "Stolen Local memory IO: %pR\n", &mem->io); > - > return 0; > > err_cleanup: > diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c > index 6f96a6b70601..af357089da6e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c > +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c > @@ -273,9 +273,6 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) > if (err) > goto err_region_put; > > - drm_dbg(&i915->drm, "Local memory: %pR\n", &mem->region); > - drm_dbg(&i915->drm, "Local memory IO: %pR\n", &mem->io); > - > if (io_size < lmem_size) > drm_info(&i915->drm, "Using a reduced BAR size of %lluMiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.\n", > (u64)io_size >> 20);
On Tue, Jan 16, 2024 at 11:23:37AM +0100, Nirmoy Das wrote: > > On 1/16/2024 8:56 AM, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Now that intel_memory_regions_hw_probe() prints out each and every > > memory region there's no reason to have ad-hoc debugs to do similar > > things elsewhere. > > > > Cc: Paz Zcharya <pazz@chromium.org> > > Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Hi Ville, Thank you so much for this incredible series. It solves the issue regarding MTL initial plane readout that Andrzej Hajda and I worked on in https://patchwork.freedesktop.org/patch/570811/?series=127130&rev=2 In addition, it solved the issue with the new GOP. I tested it on two different devices with Meteor Lake and it worked perfectly: no i915 errors, no flickers or observable issues. Tested-by: Paz Zcharya <pazz@chromium.org>
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index d2440c793f84..ee237043c302 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c @@ -828,7 +828,6 @@ static const struct intel_memory_region_ops i915_region_stolen_smem_ops = { static int init_stolen_lmem(struct intel_memory_region *mem) { - struct drm_i915_private *i915 = mem->i915; int err; if (GEM_WARN_ON(resource_size(&mem->region) == 0)) @@ -844,9 +843,6 @@ static int init_stolen_lmem(struct intel_memory_region *mem) !io_mapping_init_wc(&mem->iomap, mem->io.start, resource_size(&mem->io))) goto err_cleanup; - drm_dbg(&i915->drm, "Stolen Local DSM: %pR\n", &mem->region); - drm_dbg(&i915->drm, "Stolen Local memory IO: %pR\n", &mem->io); - return 0; err_cleanup: diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 6f96a6b70601..af357089da6e 100644 --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c @@ -273,9 +273,6 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) if (err) goto err_region_put; - drm_dbg(&i915->drm, "Local memory: %pR\n", &mem->region); - drm_dbg(&i915->drm, "Local memory IO: %pR\n", &mem->io); - if (io_size < lmem_size) drm_info(&i915->drm, "Using a reduced BAR size of %lluMiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.\n", (u64)io_size >> 20);