diff mbox series

[1/2] drm/i915/fbc: Don't use a fence for a plane if FBC is not possible

Message ID 20240123090051.29818-1-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] drm/i915/fbc: Don't use a fence for a plane if FBC is not possible | expand

Commit Message

Ville Syrjälä Jan. 23, 2024, 9 a.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

No point in wasting a fence on a plane if it can't do FBC anyway.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Govindapillai, Vinod Feb. 13, 2024, 5:32 p.m. UTC | #1
On Tue, 2024-01-23 at 11:00 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> No point in wasting a fence on a plane if it can't do FBC anyway.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index a92e959c8ac7..96a31d73f869 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -533,7 +533,7 @@ bool intel_plane_uses_fence(const struct intel_plane_state *plane_state)
>         struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
>  
>         return DISPLAY_VER(dev_priv) < 4 ||
> -               (plane->fbc &&
> +               (plane->fbc && !plane_state->no_fbc_reason &&
>                  plane_state->view.gtt.type == I915_GTT_VIEW_NORMAL);
>  }
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a92e959c8ac7..96a31d73f869 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -533,7 +533,7 @@  bool intel_plane_uses_fence(const struct intel_plane_state *plane_state)
 	struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
 
 	return DISPLAY_VER(dev_priv) < 4 ||
-		(plane->fbc &&
+		(plane->fbc && !plane_state->no_fbc_reason &&
 		 plane_state->view.gtt.type == I915_GTT_VIEW_NORMAL);
 }