| Message ID | 20240131193929.938748-4-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | HDCP Type1 MST fixes | expand |
LGTM. Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> On 2/1/2024 1:09 AM, Suraj Kandpal wrote: > Break intel_dp_hdcp2_capable so that the common the code can be > reused for the remote capability check. > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index defc90936317..9aeee6b49b3d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -636,8 +636,8 @@ int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, > } > > static > -int intel_dp_hdcp2_capable(struct intel_connector *connector, > - bool *capable) > +int _intel_dp_hdcp2_capable(struct drm_dp_aux *aux, > + bool *capable) > { > struct intel_digital_port *dig_port = intel_attached_dig_port(connector); > struct drm_dp_aux *aux = &dig_port->dp.aux; > @@ -658,6 +658,16 @@ int intel_dp_hdcp2_capable(struct intel_connector *connector, > return 0; > } > > +static > +int intel_dp_hdcp2_capable(struct intel_connector *connector, > + bool *capable) > +{ > + struct intel_digital_port *dig_port = intel_attached_dig_port(connector); > + struct drm_dp_aux *aux = &dig_port->dp.aux; > + > + return _intel_dp_hdcp2_capable(aux, capable); > +} > + > static const struct intel_hdcp_shim intel_dp_hdcp_shim = { > .write_an_aksv = intel_dp_hdcp_write_an_aksv, > .read_bksv = intel_dp_hdcp_read_bksv,
LGTM Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> On 2/1/2024 1:09 AM, Suraj Kandpal wrote: > Break intel_dp_hdcp2_capable so that the common the code can be > reused for the remote capability check. > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > index defc90936317..9aeee6b49b3d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c > @@ -636,8 +636,8 @@ int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, > } > > static > -int intel_dp_hdcp2_capable(struct intel_connector *connector, > - bool *capable) > +int _intel_dp_hdcp2_capable(struct drm_dp_aux *aux, > + bool *capable) > { > struct intel_digital_port *dig_port = intel_attached_dig_port(connector); > struct drm_dp_aux *aux = &dig_port->dp.aux; > @@ -658,6 +658,16 @@ int intel_dp_hdcp2_capable(struct intel_connector *connector, > return 0; > } > > +static > +int intel_dp_hdcp2_capable(struct intel_connector *connector, > + bool *capable) > +{ > + struct intel_digital_port *dig_port = intel_attached_dig_port(connector); > + struct drm_dp_aux *aux = &dig_port->dp.aux; > + > + return _intel_dp_hdcp2_capable(aux, capable); > +} > + > static const struct intel_hdcp_shim intel_dp_hdcp_shim = { > .write_an_aksv = intel_dp_hdcp_write_an_aksv, > .read_bksv = intel_dp_hdcp_read_bksv,
diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c index defc90936317..9aeee6b49b3d 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c @@ -636,8 +636,8 @@ int intel_dp_hdcp2_check_link(struct intel_digital_port *dig_port, } static -int intel_dp_hdcp2_capable(struct intel_connector *connector, - bool *capable) +int _intel_dp_hdcp2_capable(struct drm_dp_aux *aux, + bool *capable) { struct intel_digital_port *dig_port = intel_attached_dig_port(connector); struct drm_dp_aux *aux = &dig_port->dp.aux; @@ -658,6 +658,16 @@ int intel_dp_hdcp2_capable(struct intel_connector *connector, return 0; } +static +int intel_dp_hdcp2_capable(struct intel_connector *connector, + bool *capable) +{ + struct intel_digital_port *dig_port = intel_attached_dig_port(connector); + struct drm_dp_aux *aux = &dig_port->dp.aux; + + return _intel_dp_hdcp2_capable(aux, capable); +} + static const struct intel_hdcp_shim intel_dp_hdcp_shim = { .write_an_aksv = intel_dp_hdcp_write_an_aksv, .read_bksv = intel_dp_hdcp_read_bksv,
Break intel_dp_hdcp2_capable so that the common the code can be reused for the remote capability check. Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)