| Message ID | 20240312115757.683584-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/opregion: add intel_opregion_vbt_present() stub for ACPI=n | expand |
LGTM, Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > -----Original Message----- > From: Nikula, Jani <jani.nikula@intel.com> > Sent: Tuesday, March 12, 2024 4:58 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; Thomas Weißschuh > <thomas.weissschuh@linutronix.de>; Sripada, Radhakrishna > <radhakrishna.sripada@intel.com> > Subject: [PATCH] drm/i915/opregion: add intel_opregion_vbt_present() stub for > ACPI=n > > The opregion code needs stubs for ACPI=n. Add the missing stub for > intel_opregion_vbt_present(). > > Reported-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> > Closes: https://lore.kernel.org/r/20240312120240-afdb1b83-8517-434b-be79- > 06f41bafd71f@linutronix.de > Fixes: 9d9bb71f3e11 ("drm/i915: Extract opregion vbt presence check") > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_opregion.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h > b/drivers/gpu/drm/i915/display/intel_opregion.h > index 63573c38d735..4b2b8e752632 100644 > --- a/drivers/gpu/drm/i915/display/intel_opregion.h > +++ b/drivers/gpu/drm/i915/display/intel_opregion.h > @@ -120,6 +120,11 @@ intel_opregion_get_edid(struct intel_connector > *connector) > return NULL; > } > > +static inline bool intel_opregion_vbt_present(struct drm_i915_private *i915) > +{ > + return false; > +} > + > static inline const void * > intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size) > { > -- > 2.39.2
On Tue, 12 Mar 2024, "Sripada, Radhakrishna" <radhakrishna.sripada@intel.com> wrote: > LGTM, > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> Thanks for the review, pushed to drm-intel-next. BR, Jani.
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h b/drivers/gpu/drm/i915/display/intel_opregion.h index 63573c38d735..4b2b8e752632 100644 --- a/drivers/gpu/drm/i915/display/intel_opregion.h +++ b/drivers/gpu/drm/i915/display/intel_opregion.h @@ -120,6 +120,11 @@ intel_opregion_get_edid(struct intel_connector *connector) return NULL; } +static inline bool intel_opregion_vbt_present(struct drm_i915_private *i915) +{ + return false; +} + static inline const void * intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size) {
The opregion code needs stubs for ACPI=n. Add the missing stub for intel_opregion_vbt_present(). Reported-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Closes: https://lore.kernel.org/r/20240312120240-afdb1b83-8517-434b-be79-06f41bafd71f@linutronix.de Fixes: 9d9bb71f3e11 ("drm/i915: Extract opregion vbt presence check") Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_opregion.h | 5 +++++ 1 file changed, 5 insertions(+)