| Message ID | 20240328122236.1718111-2-alexander.usyskin@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: add driver for Intel discrete graphics | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, March 29, 2024 15:47 > To: Usyskin, Alexander <alexander.usyskin@intel.com>; Miquel Raynal > <miquel.raynal@bootlin.com>; Richard Weinberger <richard@nod.at>; Vignesh > Raghavendra <vigneshr@ti.com>; Jani Nikula <jani.nikula@linux.intel.com>; > Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo > <rodrigo.vivi@intel.com> > Cc: Lubart, Vitaly <vitaly.lubart@intel.com>; linux-mtd@lists.infradead.org; intel- > gfx@lists.freedesktop.org > Subject: Re: [PATCH 01/13] spi: add auxiliary device for intel dg spi > > On 28/03/2024 13:22, Alexander Usyskin wrote: > > Add auxilary bus device structure for > > Intel Discrete Graphics SPI device. > > > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > > --- > > include/linux/intel_dg_spi_aux.h | 27 +++++++++++++++++++++++++++ > > There is no user of this header. Please add it in the patch which uses it. > This header describes auxiliary device that bridges between i915 or Xe driver with spi-intel-dg driver. This header included in both drivers; this is the reason this header has its own patch. > It will also justify why you use this or other subject prefix. Now, it > looks just wrong: it's not a patch for spi. > Can you suggest what subject prefix to use? Like: "auxiliary:"? Something else? > If it was a patch for spi, then: > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC (and consider --no-git-fallback argument). It might > happen, that command when run on an older kernel, gives you outdated > entries. Therefore please be sure you base your patches on recent Linux > kernel. > Sorry for that, will run this script to pick the fresh maintainers list and push v2 with a new list. > Best regards, > Krzysztof
diff --git a/include/linux/intel_dg_spi_aux.h b/include/linux/intel_dg_spi_aux.h new file mode 100644 index 000000000000..d4c3830d56d6 --- /dev/null +++ b/include/linux/intel_dg_spi_aux.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright(c) 2019-2024, Intel Corporation. All rights reserved. + */ + +#ifndef __INTEL_DG_SPI_AUX_H__ +#define __INTEL_DG_SPI_AUX_H__ + +#include <linux/auxiliary_bus.h> + +#define INTEL_DG_SPI_REGIONS 13 + +struct intel_dg_spi_region { + const char *name; +}; + +struct intel_dg_spi_dev { + struct auxiliary_device aux_dev; + bool writeable_override; + struct resource bar; + const struct intel_dg_spi_region *regions; +}; + +#define auxiliary_dev_to_intel_dg_spi_dev(auxiliary_dev) \ + container_of(auxiliary_dev, struct intel_dg_spi_dev, aux_dev) + +#endif /* __INTEL_DG_SPI_AUX_H__ */
Add auxilary bus device structure for Intel Discrete Graphics SPI device. Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> --- include/linux/intel_dg_spi_aux.h | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 include/linux/intel_dg_spi_aux.h