| Message ID | 20240404032931.380887-6-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Enable Aux Based EDP HDR | expand |
On Thu, Apr 04, 2024 at 08:59:28AM +0530, Suraj Kandpal wrote: > Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 3d9723714c96..2d50a4734823 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -69,14 +69,14 @@ > #define INTEL_EDP_HDR_GETSET_CTRL_PARAMS 0x344 > # define INTEL_EDP_HDR_TCON_2084_DECODE_ENABLE BIT(0) > # define INTEL_EDP_HDR_TCON_2020_GAMUT_ENABLE BIT(1) > -# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE BIT(2) /* Pre-TGL+ */ > +# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE BIT(2) /* Pre-ICL */ Technically that's also true for 2084_DECODE_ENABLE and 2020_GAMUT_ENABLE. Maybe just drop the comment? What is enabled when should become clear from the code. > # define INTEL_EDP_HDR_TCON_SEGMENTED_BACKLIGHT_ENABLE BIT(3) > # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE BIT(4) > # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE BIT(5) > /* Bit 6 is reserved */ > # define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX BIT(7) > > -#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 /* Pre-TGL+ */ > +#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 /* Pre-ICL */ > #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE 0x34A > #define INTEL_EDP_SDR_LUMINANCE_LEVEL 0x352 > #define INTEL_EDP_BRIGHTNESS_NITS_LSB 0x354
> -----Original Message----- > From: Sebastian Wick <sebastian.wick@redhat.com> > Sent: Friday, April 5, 2024 10:55 PM > To: Kandpal, Suraj <suraj.kandpal@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Borah, Chaitanya Kumar > <chaitanya.kumar.borah@intel.com>; Shankar, Uma > <uma.shankar@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; > Murthy, Arun R <arun.r.murthy@intel.com>; Syrjala, Ville > <ville.syrjala@intel.com>; Kumar, Naveen1 <naveen1.kumar@intel.com> > Subject: Re: [4/7] drm/i915/dp: Fix comments on EDP HDR DPCD registers > > On Thu, Apr 04, 2024 at 08:59:28AM +0530, Suraj Kandpal wrote: > > Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs > > > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > index 3d9723714c96..2d50a4734823 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > > @@ -69,14 +69,14 @@ > > #define INTEL_EDP_HDR_GETSET_CTRL_PARAMS 0x344 > > # define INTEL_EDP_HDR_TCON_2084_DECODE_ENABLE > BIT(0) > > # define INTEL_EDP_HDR_TCON_2020_GAMUT_ENABLE > BIT(1) > > -# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE > BIT(2) /* Pre-TGL+ */ > > +# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE > BIT(2) /* Pre-ICL */ > > Technically that's also true for 2084_DECODE_ENABLE and > 2020_GAMUT_ENABLE. Maybe just drop the comment? What is enabled > when should become clear from the code. Sure will drop the comments altogether. Regards, Suraj Kandpal > > > # define INTEL_EDP_HDR_TCON_SEGMENTED_BACKLIGHT_ENABLE > BIT(3) > > # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE > BIT(4) > > # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE > BIT(5) > > /* Bit 6 is reserved */ > > # define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX > BIT(7) > > > > -#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 > /* Pre-TGL+ */ > > +#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 > /* Pre-ICL */ > > #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE > 0x34A > > #define INTEL_EDP_SDR_LUMINANCE_LEVEL 0x352 > > #define INTEL_EDP_BRIGHTNESS_NITS_LSB 0x354
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 3d9723714c96..2d50a4734823 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -69,14 +69,14 @@ #define INTEL_EDP_HDR_GETSET_CTRL_PARAMS 0x344 # define INTEL_EDP_HDR_TCON_2084_DECODE_ENABLE BIT(0) # define INTEL_EDP_HDR_TCON_2020_GAMUT_ENABLE BIT(1) -# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE BIT(2) /* Pre-TGL+ */ +# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE BIT(2) /* Pre-ICL */ # define INTEL_EDP_HDR_TCON_SEGMENTED_BACKLIGHT_ENABLE BIT(3) # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE BIT(4) # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE BIT(5) /* Bit 6 is reserved */ # define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX BIT(7) -#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 /* Pre-TGL+ */ +#define INTEL_EDP_HDR_CONTENT_LUMINANCE 0x346 /* Pre-ICL */ #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE 0x34A #define INTEL_EDP_SDR_LUMINANCE_LEVEL 0x352 #define INTEL_EDP_BRIGHTNESS_NITS_LSB 0x354
Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)