| Message ID | 20240405065159.439145-1-mitulkumar.ajitkumar.golani@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/dp: correct struct member name in documentation | expand |
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > --- > include/drm/display/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Hi Mitul, Thanks. On Fri, 5 Apr 2024 12:21:59 +0530 Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> wrote: > > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Probably good to avoid this 'Fixes:' tag, and only use that for real code bugs. Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> drm-misc folks, ack to get this through drm-intel-next, where the original patch is? Thanks, Rodrigo > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > --- > include/drm/display/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h > index baf9949ff96f..6799f57d635c 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > * @target_rr: Target Refresh > * @duration_incr_ms: Successive frame duration increase > * @duration_decr_ms: Successive frame duration decrease > - * @operation_mode: Adaptive Sync Operation Mode > + * @mode: Adaptive Sync Operation Mode > */ > struct drm_dp_as_sdp { > unsigned char sdp_type; > -- > 2.25.1 >
> -----Original Message----- > From: Vivi, Rodrigo <rodrigo.vivi@intel.com> > Sent: Wednesday, April 10, 2024 9:49 PM > To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@intel.com>; > tzimmermann@suse.de; mripard@kernel.org; > maarten.lankhorst@linux.intel.com > Cc: dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Nautiyal, > Ankit K <ankit.k.nautiyal@intel.com>; Nikula, Jani <jani.nikula@intel.com>; > sfr@canb.auug.org.au > Subject: Re: [PATCH] drm/dp: correct struct member name in documentation > > On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > > Correct struct member name to 'mode' instead of 'operation mode' > > in 'drm_dp_as_sdp' structure description. > > > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > > Probably good to avoid this 'Fixes:' tag, and only use that for real code bugs. Thank you for inputs.. I understood and I will take the future note. Please suggest if required to update the change with new revision or we can take care while merge.. ? > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > drm-misc folks, ack to get this through drm-intel-next, where the original patch > is? > > Thanks, > Rodrigo > > > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > > Cc: Jani Nikula <jani.nikula@intel.com> > > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > > > --- > > include/drm/display/drm_dp_helper.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/drm/display/drm_dp_helper.h > > b/include/drm/display/drm_dp_helper.h > > index baf9949ff96f..6799f57d635c 100644 > > --- a/include/drm/display/drm_dp_helper.h > > +++ b/include/drm/display/drm_dp_helper.h > > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > > * @target_rr: Target Refresh > > * @duration_incr_ms: Successive frame duration increase > > * @duration_decr_ms: Successive frame duration decrease > > - * @operation_mode: Adaptive Sync Operation Mode > > + * @mode: Adaptive Sync Operation Mode > > */ > > struct drm_dp_as_sdp { > > unsigned char sdp_type; > > -- > > 2.25.1 > >
On Thu, Apr 11, 2024 at 12:55:29PM -0400, Golani, Mitulkumar Ajitkumar wrote: > > > > -----Original Message----- > > From: Vivi, Rodrigo <rodrigo.vivi@intel.com> > > Sent: Wednesday, April 10, 2024 9:49 PM > > To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@intel.com>; > > tzimmermann@suse.de; mripard@kernel.org; > > maarten.lankhorst@linux.intel.com > > Cc: dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Nautiyal, > > Ankit K <ankit.k.nautiyal@intel.com>; Nikula, Jani <jani.nikula@intel.com>; > > sfr@canb.auug.org.au > > Subject: Re: [PATCH] drm/dp: correct struct member name in documentation > > > > On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > > > Correct struct member name to 'mode' instead of 'operation mode' > > > in 'drm_dp_as_sdp' structure description. > > > > > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > > > > Probably good to avoid this 'Fixes:' tag, and only use that for real code bugs. > > Thank you for inputs.. I understood and I will take the future note. Please suggest if required to update the change with new revision or we can take care while merge.. ? I can remove it while merging. I just need an ack from drm or drm-misc maintainers to merge this through drm-intel-next. Sima, Dave? > > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > > > drm-misc folks, ack to get this through drm-intel-next, where the original patch > > is? > > > > Thanks, > > Rodrigo > > > > > Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > > > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > > > > > --- > > > include/drm/display/drm_dp_helper.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/drm/display/drm_dp_helper.h > > > b/include/drm/display/drm_dp_helper.h > > > index baf9949ff96f..6799f57d635c 100644 > > > --- a/include/drm/display/drm_dp_helper.h > > > +++ b/include/drm/display/drm_dp_helper.h > > > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > > > * @target_rr: Target Refresh > > > * @duration_incr_ms: Successive frame duration increase > > > * @duration_decr_ms: Successive frame duration decrease > > > - * @operation_mode: Adaptive Sync Operation Mode > > > + * @mode: Adaptive Sync Operation Mode > > > */ > > > struct drm_dp_as_sdp { > > > unsigned char sdp_type; > > > -- > > > 2.25.1 > > >
diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index baf9949ff96f..6799f57d635c 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { * @target_rr: Target Refresh * @duration_incr_ms: Successive frame duration increase * @duration_decr_ms: Successive frame duration decrease - * @operation_mode: Adaptive Sync Operation Mode + * @mode: Adaptive Sync Operation Mode */ struct drm_dp_as_sdp { unsigned char sdp_type;
Correct struct member name to 'mode' instead of 'operation mode' in 'drm_dp_as_sdp' structure description. Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> --- include/drm/display/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)