| Message ID | 20240412213342.181465-1-vinod.govindapillai@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] drm/xe: no need to call fixup_initial_plane_config in XE | expand |
On Sat, Apr 13, 2024 at 12:33:42AM +0300, Vinod Govindapillai wrote: > In XE, the updated fb mapping is already done and updated as > part of intel_find_initial_plane_obj(). So no need to invoke > fixup_initial_plane_config() again as it would basically write > the same data to "PLAN_SURF" again. > > Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com> > --- > drivers/gpu/drm/xe/display/xe_plane_initial.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c > index 9693c56d386b..51eb80729cfb 100644 > --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c > +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c > @@ -297,9 +297,6 @@ void intel_initial_plane_config(struct drm_i915_private *i915) > */ > intel_find_initial_plane_obj(crtc, plane_configs); > > - if (i915->display.funcs.display->fixup_initial_plane_config(crtc, plane_config)) > - intel_crtc_wait_for_next_vblank(crtc); > - We want to do the opposite. ie. get rid rid of the async flip abuse in xe. > plane_config_fini(plane_config); > } > } > -- > 2.34.1
diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c index 9693c56d386b..51eb80729cfb 100644 --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c @@ -297,9 +297,6 @@ void intel_initial_plane_config(struct drm_i915_private *i915) */ intel_find_initial_plane_obj(crtc, plane_configs); - if (i915->display.funcs.display->fixup_initial_plane_config(crtc, plane_config)) - intel_crtc_wait_for_next_vblank(crtc); - plane_config_fini(plane_config); } }
In XE, the updated fb mapping is already done and updated as part of intel_find_initial_plane_obj(). So no need to invoke fixup_initial_plane_config() again as it would basically write the same data to "PLAN_SURF" again. Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com> --- drivers/gpu/drm/xe/display/xe_plane_initial.c | 3 --- 1 file changed, 3 deletions(-)