| Message ID | 20240506090625.2812332-1-arun.r.murthy@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/display/dp: Remove UHBR13.5 for icl | expand |
On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy wrote: > UHBR13.5 is not supported in icl+ as well. This has been removed for mtl > by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") icl/tgl/adl don't support UHBR at all. The numbers are there for dg2 presumably, which I think does support this. > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 163da48bc406..7098ca65701f 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -507,7 +507,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) > }; > static const int icl_rates[] = { > 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000, > - 1000000, 1350000, > + 1000000, > }; > static const int bxt_rates[] = { > 162000, 216000, 243000, 270000, 324000, 432000, 540000 > -- > 2.25.1
> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Monday, May 6, 2024 5:36 PM > To: Murthy, Arun R <arun.r.murthy@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com> > Subject: Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy wrote: > > UHBR13.5 is not supported in icl+ as well. This has been removed for > > mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support for > > UHBR13.5") > > icl/tgl/adl don't support UHBR at all. The numbers are there for dg2 > presumably, which I think does support this. As per the recommendation from hardware team this is not supported on DG2 and MTL. Thanks and Regards, Arun R Murthy ------------------- > > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > b/drivers/gpu/drm/i915/display/intel_dp.c > > index 163da48bc406..7098ca65701f 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -507,7 +507,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) > > }; > > static const int icl_rates[] = { > > 162000, 216000, 270000, 324000, 432000, 540000, 648000, > 810000, > > - 1000000, 1350000, > > + 1000000, > > }; > > static const int bxt_rates[] = { > > 162000, 216000, 243000, 270000, 324000, 432000, 540000 > > -- > > 2.25.1 > > -- > Ville Syrjälä > Intel
On Mon, May 06, 2024 at 12:15:13PM +0000, Murthy, Arun R wrote: > > > -----Original Message----- > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Sent: Monday, May 6, 2024 5:36 PM > > To: Murthy, Arun R <arun.r.murthy@intel.com> > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com> > > Subject: Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > > > On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy wrote: > > > UHBR13.5 is not supported in icl+ as well. This has been removed for > > > mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support for > > > UHBR13.5") > > > > icl/tgl/adl don't support UHBR at all. The numbers are there for dg2 > > presumably, which I think does support this. > As per the recommendation from hardware team this is not supported on DG2 and MTL. That is not what bspec says. > > Thanks and Regards, > Arun R Murthy > ------------------- > > > > > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > > b/drivers/gpu/drm/i915/display/intel_dp.c > > > index 163da48bc406..7098ca65701f 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > @@ -507,7 +507,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) > > > }; > > > static const int icl_rates[] = { > > > 162000, 216000, 270000, 324000, 432000, 540000, 648000, > > 810000, > > > - 1000000, 1350000, > > > + 1000000, > > > }; > > > static const int bxt_rates[] = { > > > 162000, 216000, 243000, 270000, 324000, 432000, 540000 > > > -- > > > 2.25.1 > > > > -- > > Ville Syrjälä > > Intel
> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Monday, May 6, 2024 5:51 PM > To: Murthy, Arun R <arun.r.murthy@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com> > Subject: Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Mon, May 06, 2024 at 12:15:13PM +0000, Murthy, Arun R wrote: > > > > > -----Original Message----- > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > Sent: Monday, May 6, 2024 5:36 PM > > > To: Murthy, Arun R <arun.r.murthy@intel.com> > > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani > > > <jani.nikula@intel.com> > > > Subject: Re: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > > > > > On Mon, May 06, 2024 at 02:36:25PM +0530, Arun R Murthy wrote: > > > > UHBR13.5 is not supported in icl+ as well. This has been removed > > > > for mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support > > > > for > > > > UHBR13.5") > > > > > > icl/tgl/adl don't support UHBR at all. The numbers are there for dg2 > > > presumably, which I think does support this. > > As per the recommendation from hardware team this is not supported on > DG2 and MTL. > > That is not what bspec says. > This is the limitation from the retimer hardware. Thanks and Regards, Arun R Murthy ------------------- > > > > Thanks and Regards, > > Arun R Murthy > > ------------------- > > > > > > > > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > > > b/drivers/gpu/drm/i915/display/intel_dp.c > > > > index 163da48bc406..7098ca65701f 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > > @@ -507,7 +507,7 @@ intel_dp_set_source_rates(struct intel_dp > *intel_dp) > > > > }; > > > > static const int icl_rates[] = { > > > > 162000, 216000, 270000, 324000, 432000, 540000, 648000, > > > 810000, > > > > - 1000000, 1350000, > > > > + 1000000, > > > > }; > > > > static const int bxt_rates[] = { > > > > 162000, 216000, 243000, 270000, 324000, 432000, 540000 > > > > -- > > > > 2.25.1 > > > > > > -- > > > Ville Syrjälä > > > Intel > > -- > Ville Syrjälä > Intel
On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
> This is the limitation from the retimer hardware.
The commit message needs to reflect this.
Do all units have a retimer with the limitation? Or could you have a DG2
without the limitation? Do we need to check for that instead of blanket
removal of UHBR 13.5 for DG2?
BR,
Jani.
On Wed, May 08, 2024 at 12:58:46PM +0300, Jani Nikula wrote: > On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: > > This is the limitation from the retimer hardware. > > The commit message needs to reflect this. > > Do all units have a retimer with the limitation? Or could you have a DG2 > without the limitation? Do we need to check for that instead of blanket > removal of UHBR 13.5 for DG2? And if we do remove it entirely then we should do it fully. That is, don't leave behind unused PLL tables and whatnot.
> -----Original Message----- > From: Nikula, Jani <jani.nikula@intel.com> > Sent: Wednesday, May 8, 2024 3:29 PM > To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä > <ville.syrjala@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: > > This is the limitation from the retimer hardware. > > The commit message needs to reflect this. > > Do all units have a retimer with the limitation? Or could you have a DG2 > without the limitation? Do we need to check for that instead of blanket removal > of UHBR 13.5 for DG2? > Changed the commit msg as below Display 12+ hardware supports UHBR13.5 but due to the retimer constraints platform doesn't support UHBR13.5. This is the same for mtl and UHBR13.5 is removed as part of the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") This patch removes UHBR13.5 support for icl/dg2. Thanks and Regards, Arun R Murthy -------------------- > BR, > Jani. > > > -- > Jani Nikula, Intel
On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: >> -----Original Message----- >> From: Nikula, Jani <jani.nikula@intel.com> >> Sent: Wednesday, May 8, 2024 3:29 PM >> To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä >> <ville.syrjala@linux.intel.com> >> Cc: intel-gfx@lists.freedesktop.org >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl >> >> On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: >> > This is the limitation from the retimer hardware. >> >> The commit message needs to reflect this. >> >> Do all units have a retimer with the limitation? Or could you have a DG2 >> without the limitation? Do we need to check for that instead of blanket removal >> of UHBR 13.5 for DG2? >> > Changed the commit msg as below > > Display 12+ hardware supports UHBR13.5 Not true. > but due to the retimer constraints platform doesn't support UHBR13.5. Which platform? > This is the same for mtl and UHBR13.5 is removed as part of the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") > This patch removes UHBR13.5 support for icl/dg2. ICL does not support UHBR 13.5. BR, Jani. > > Thanks and Regards, > Arun R Murthy > -------------------- >> BR, >> Jani. >> >> >> -- >> Jani Nikula, Intel
> -----Original Message----- > From: Nikula, Jani <jani.nikula@intel.com> > Sent: Wednesday, May 8, 2024 5:18 PM > To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä > <ville.syrjala@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > > On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: > >> -----Original Message----- > >> From: Nikula, Jani <jani.nikula@intel.com> > >> Sent: Wednesday, May 8, 2024 3:29 PM > >> To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä > >> <ville.syrjala@linux.intel.com> > >> Cc: intel-gfx@lists.freedesktop.org > >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl > >> > >> On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: > >> > This is the limitation from the retimer hardware. > >> > >> The commit message needs to reflect this. > >> > >> Do all units have a retimer with the limitation? Or could you have a > >> DG2 without the limitation? Do we need to check for that instead of > >> blanket removal of UHBR 13.5 for DG2? > >> > > Changed the commit msg as below > > > > Display 12+ hardware supports UHBR13.5 > > Not true. > > > but due to the retimer constraints platform doesn't support UHBR13.5. > > Which platform? > > > This is the same for mtl and UHBR13.5 is removed as part of the commit > > caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") This patch > removes UHBR13.5 support for icl/dg2. > > ICL does not support UHBR 13.5. > Per bspec display12+ has uhbr13.5 Due to the retimer constraint none of the Intel platforms supports UHBR13.5 Uhbr15.3 is already removed for mtl platform as part of commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") this patch will remove for dg2. Thanks and Regards, Arun R Murthy -------------------- > BR, > Jani. > > > > > Thanks and Regards, > > Arun R Murthy > > -------------------- > >> BR, > >> Jani. > >> > >> > >> -- > >> Jani Nikula, Intel > > -- > Jani Nikula, Intel
On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: >> -----Original Message----- >> From: Nikula, Jani <jani.nikula@intel.com> >> Sent: Wednesday, May 8, 2024 5:18 PM >> To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä >> <ville.syrjala@linux.intel.com> >> Cc: intel-gfx@lists.freedesktop.org >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl >> >> On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: >> >> -----Original Message----- >> >> From: Nikula, Jani <jani.nikula@intel.com> >> >> Sent: Wednesday, May 8, 2024 3:29 PM >> >> To: Murthy, Arun R <arun.r.murthy@intel.com>; Ville Syrjälä >> >> <ville.syrjala@linux.intel.com> >> >> Cc: intel-gfx@lists.freedesktop.org >> >> Subject: RE: [PATCH] drm/i915/display/dp: Remove UHBR13.5 for icl >> >> >> >> On Wed, 08 May 2024, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote: >> >> > This is the limitation from the retimer hardware. >> >> >> >> The commit message needs to reflect this. >> >> >> >> Do all units have a retimer with the limitation? Or could you have a >> >> DG2 without the limitation? Do we need to check for that instead of >> >> blanket removal of UHBR 13.5 for DG2? >> >> >> > Changed the commit msg as below >> > >> > Display 12+ hardware supports UHBR13.5 >> >> Not true. >> >> > but due to the retimer constraints platform doesn't support UHBR13.5. >> >> Which platform? >> >> > This is the same for mtl and UHBR13.5 is removed as part of the commit >> > caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") This patch >> removes UHBR13.5 support for icl/dg2. >> >> ICL does not support UHBR 13.5. >> > > Per bspec display12+ has uhbr13.5 Due to the retimer constraint none of the Intel platforms supports UHBR13.5 > Uhbr15.3 is already removed for mtl platform as part of commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") this patch will remove for dg2. Where does display 12+ come from? We support UHBR starting from DG2 and display version 14+, right? BR, Jani. > > Thanks and Regards, > Arun R Murthy > -------------------- >> BR, >> Jani. >> >> > >> > Thanks and Regards, >> > Arun R Murthy >> > -------------------- >> >> BR, >> >> Jani. >> >> >> >> >> >> -- >> >> Jani Nikula, Intel >> >> -- >> Jani Nikula, Intel
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 163da48bc406..7098ca65701f 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -507,7 +507,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) }; static const int icl_rates[] = { 162000, 216000, 270000, 324000, 432000, 540000, 648000, 810000, - 1000000, 1350000, + 1000000, }; static const int bxt_rates[] = { 162000, 216000, 243000, 270000, 324000, 432000, 540000
UHBR13.5 is not supported in icl+ as well. This has been removed for mtl by the commit caf3d748f646 ("drm/i915/dp: Remove support for UHBR13.5") Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)