diff mbox series

[3/9] drm/i915: Drop 'uses_fence' parameter from intel_pin_fb_obj_dpt()

Message ID 20240506125718.26001-4-ville.syrjala@linux.intel.com (mailing list archive)
State New
Headers show
Series drm/i915: Plane fb refactoring | expand

Commit Message

Ville Syrjala May 6, 2024, 12:57 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Fence regions are only relevant for GGTT, not DPT. Drop the
pointless 'uses_fence' argument from intel_pin_fb_obj_dpt().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Jani Nikula May 6, 2024, 2:04 p.m. UTC | #1 
On Mon, 06 May 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fence regions are only relevant for GGTT, not DPT. Drop the
> pointless 'uses_fence' argument from intel_pin_fb_obj_dpt().
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> index be095cc696ba..2b50c1946c63 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
> @@ -20,7 +20,6 @@ static struct i915_vma *
>  intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
>  		     const struct i915_gtt_view *view,
>  		     unsigned int alignment,
> -		     bool uses_fence,
>  		     unsigned long *out_flags,
>  		     struct i915_address_space *vm)
>  {
> @@ -274,8 +273,8 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)
>  		plane_state->ggtt_vma = vma;
>  
>  		vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt,
> -					   alignment, false,
> -					   &plane_state->flags, intel_fb->dpt_vm);
> +					   alignment, &plane_state->flags,
> +					   intel_fb->dpt_vm);
>  		if (IS_ERR(vma)) {
>  			intel_dpt_unpin(intel_fb->dpt_vm);
>  			plane_state->ggtt_vma = NULL;
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index be095cc696ba..2b50c1946c63 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
@@ -20,7 +20,6 @@  static struct i915_vma *
 intel_pin_fb_obj_dpt(struct drm_framebuffer *fb,
 		     const struct i915_gtt_view *view,
 		     unsigned int alignment,
-		     bool uses_fence,
 		     unsigned long *out_flags,
 		     struct i915_address_space *vm)
 {
@@ -274,8 +273,8 @@  int intel_plane_pin_fb(struct intel_plane_state *plane_state)
 		plane_state->ggtt_vma = vma;
 
 		vma = intel_pin_fb_obj_dpt(fb, &plane_state->view.gtt,
-					   alignment, false,
-					   &plane_state->flags, intel_fb->dpt_vm);
+					   alignment, &plane_state->flags,
+					   intel_fb->dpt_vm);
 		if (IS_ERR(vma)) {
 			intel_dpt_unpin(intel_fb->dpt_vm);
 			plane_state->ggtt_vma = NULL;