| Message ID | 20240726084022.356654-6-janusz.krzysztofik@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/device_reset: Wait for device nodes to re-appear | expand |
Hi Janusz, On 2024-07-26 at 10:34:57 +0200, Janusz Krzysztofik wrote: > The comment incorrectly blames udev for being responsible for delays in > re-creation of device nodes after driver rebind. While that could be > true many years ago, nowadays that's the role of kernel devtmpfs. Thank you for clarification, Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com> > > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > --- > tests/core_hotunplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c > index db7a5c5e84..145fe141ed 100644 > --- a/tests/core_hotunplug.c > +++ b/tests/core_hotunplug.c > @@ -480,7 +480,7 @@ static void node_healthcheck(struct hotunplug *priv, unsigned flags) > > static bool healthcheck(struct hotunplug *priv, bool recover) > { > - /* give udev some time to recreate device nodes before we continue */ > + /* give devtmpfs some time to recreate device nodes before we continue */ > sleep(1); > > /* device name may have changed, rebuild IGT device list */ > -- > 2.45.2 >
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index db7a5c5e84..145fe141ed 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -480,7 +480,7 @@ static void node_healthcheck(struct hotunplug *priv, unsigned flags) static bool healthcheck(struct hotunplug *priv, bool recover) { - /* give udev some time to recreate device nodes before we continue */ + /* give devtmpfs some time to recreate device nodes before we continue */ sleep(1); /* device name may have changed, rebuild IGT device list */
The comment incorrectly blames udev for being responsible for delays in re-creation of device nodes after driver rebind. While that could be true many years ago, nowadays that's the role of kernel devtmpfs. Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> --- tests/core_hotunplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)