| Message ID | 20240729040829.3753012-1-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro | expand |
On Mon, 29 Jul 2024, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > Fix HDCP2_STREAM_STATUS macro, it called pipe instead of port never > threw a compile error as no one used it. Fixes: ? > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_hdcp_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > index a568a457e532..f590d7f48ba7 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > @@ -251,7 +251,7 @@ > #define HDCP2_STREAM_STATUS(dev_priv, trans, port) \ > (TRANS_HDCP(dev_priv) ? \ > TRANS_HDCP2_STREAM_STATUS(trans) : \ > - PIPE_HDCP2_STREAM_STATUS(pipe)) > + PIPE_HDCP2_STREAM_STATUS(port)) > > #define _PORTA_HDCP2_AUTH_STREAM 0x66F00 > #define _PORTB_HDCP2_AUTH_STREAM 0x66F04
> -----Original Message----- > From: Jani Nikula <jani.nikula@linux.intel.com> > Sent: Monday, July 29, 2024 3:26 PM > To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Kandpal, Suraj > <suraj.kandpal@intel.com> > Subject: Re: [PATCH] drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro > > On Mon, 29 Jul 2024, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > > Fix HDCP2_STREAM_STATUS macro, it called pipe instead of port never > > threw a compile error as no one used it. > > Fixes: ? > Anyway to find it, Did a git blame but since one of your patches separated intel_hdcp_regs.h from i915_regs.h All I can see is your commit which I don't think is the correct commit to add. Regards, Suraj Kandpal > > > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_hdcp_regs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > > b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > > index a568a457e532..f590d7f48ba7 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h > > @@ -251,7 +251,7 @@ > > #define HDCP2_STREAM_STATUS(dev_priv, trans, port) \ > > (TRANS_HDCP(dev_priv) ? \ > > > TRANS_HDCP2_STREAM_STATUS(trans) : \ > > - PIPE_HDCP2_STREAM_STATUS(pipe)) > > + PIPE_HDCP2_STREAM_STATUS(port)) > > > > #define _PORTA_HDCP2_AUTH_STREAM 0x66F00 > > #define _PORTB_HDCP2_AUTH_STREAM 0x66F04 > > -- > Jani Nikula, Intel
On Mon, 29 Jul 2024, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote: >> -----Original Message----- >> From: Jani Nikula <jani.nikula@linux.intel.com> >> Sent: Monday, July 29, 2024 3:26 PM >> To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel- >> gfx@lists.freedesktop.org >> Cc: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Kandpal, Suraj >> <suraj.kandpal@intel.com> >> Subject: Re: [PATCH] drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro >> >> On Mon, 29 Jul 2024, Suraj Kandpal <suraj.kandpal@intel.com> wrote: >> > Fix HDCP2_STREAM_STATUS macro, it called pipe instead of port never >> > threw a compile error as no one used it. >> >> Fixes: ? >> > > Anyway to find it, > Did a git blame but since one of your patches separated intel_hdcp_regs.h from i915_regs.h > All I can see is your commit which I don't think is the correct commit to add. Please just dig deeper. git blaming through refactoring is an essential skill. BR, Jani. > > Regards, > Suraj Kandpal > >> > >> > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> >> > --- >> > drivers/gpu/drm/i915/display/intel_hdcp_regs.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > index a568a457e532..f590d7f48ba7 100644 >> > --- a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h >> > @@ -251,7 +251,7 @@ >> > #define HDCP2_STREAM_STATUS(dev_priv, trans, port) \ >> > (TRANS_HDCP(dev_priv) ? \ >> > >> TRANS_HDCP2_STREAM_STATUS(trans) : \ >> > - PIPE_HDCP2_STREAM_STATUS(pipe)) >> > + PIPE_HDCP2_STREAM_STATUS(port)) >> > >> > #define _PORTA_HDCP2_AUTH_STREAM 0x66F00 >> > #define _PORTB_HDCP2_AUTH_STREAM 0x66F04 >> >> -- >> Jani Nikula, Intel
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h index a568a457e532..f590d7f48ba7 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp_regs.h +++ b/drivers/gpu/drm/i915/display/intel_hdcp_regs.h @@ -251,7 +251,7 @@ #define HDCP2_STREAM_STATUS(dev_priv, trans, port) \ (TRANS_HDCP(dev_priv) ? \ TRANS_HDCP2_STREAM_STATUS(trans) : \ - PIPE_HDCP2_STREAM_STATUS(pipe)) + PIPE_HDCP2_STREAM_STATUS(port)) #define _PORTA_HDCP2_AUTH_STREAM 0x66F00 #define _PORTB_HDCP2_AUTH_STREAM 0x66F04
Fix HDCP2_STREAM_STATUS macro, it called pipe instead of port never threw a compile error as no one used it. Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_hdcp_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)