| Message ID | 20240729173320.1053791-1-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/bios: remove stale and useless comments | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Monday, July 29, 2024 11:03 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com> > Subject: [PATCH] drm/i915/bios: remove stale and useless comments > > The comments do not add any value. Remove. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- LGTM. Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com> Thanks, Vandita > drivers/gpu/drm/i915/display/intel_bios.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c > b/drivers/gpu/drm/i915/display/intel_bios.c > index 02443462bec3..460e83f0d5a5 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -1692,14 +1692,6 @@ parse_mipi_config(struct drm_i915_private *i915, > /* Initialize this to undefined indicating no generic MIPI support */ > panel->vbt.dsi.panel_id = MIPI_DSI_UNDEFINED_PANEL_ID; > > - /* Block #40 is already parsed and panel_fixed_mode is > - * stored in i915->lfp_vbt_mode > - * resuse this when needed > - */ > - > - /* Parse #52 for panel index used from panel_type already > - * parsed > - */ > start = bdb_find_section(i915, BDB_MIPI_CONFIG); > if (!start) { > drm_dbg_kms(&i915->drm, "No MIPI config BDB found"); > -- > 2.39.2
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index 02443462bec3..460e83f0d5a5 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -1692,14 +1692,6 @@ parse_mipi_config(struct drm_i915_private *i915, /* Initialize this to undefined indicating no generic MIPI support */ panel->vbt.dsi.panel_id = MIPI_DSI_UNDEFINED_PANEL_ID; - /* Block #40 is already parsed and panel_fixed_mode is - * stored in i915->lfp_vbt_mode - * resuse this when needed - */ - - /* Parse #52 for panel index used from panel_type already - * parsed - */ start = bdb_find_section(i915, BDB_MIPI_CONFIG); if (!start) { drm_dbg_kms(&i915->drm, "No MIPI config BDB found");
The comments do not add any value. Remove. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_bios.c | 8 -------- 1 file changed, 8 deletions(-)