diff mbox series

[CI] drm/i915/dmc: Hardcode path to MTL DMC v2.22

Message ID 20240729200441.2337924-1-dnyaneshwar.bhadane@intel.com (mailing list archive)
State New, archived
Headers show
Series [CI] drm/i915/dmc: Hardcode path to MTL DMC v2.22 | expand

Commit Message

Dnyaneshwar Bhadane July 29, 2024, 8:04 p.m. UTC
NOT TO BE REVIEWED/MERGED
Hardcode path to DMC firmware for CI purposes only.

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gustavo Sousa July 29, 2024, 8:14 p.m. UTC | #1
Quoting Dnyaneshwar Bhadane (2024-07-29 17:04:41-03:00)
>NOT TO BE REVIEWED/MERGED
>Hardcode path to DMC firmware for CI purposes only.
>
>Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>index 73977b173898..5ef22a76c11e 100644
>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>@@ -119,7 +119,7 @@ MODULE_FIRMWARE(XE2LPD_DMC_PATH);
> #define BMG_DMC_PATH                        DMC_PATH(bmg)
> MODULE_FIRMWARE(BMG_DMC_PATH);
> 
>-#define MTL_DMC_PATH                        DMC_PATH(mtl)
>+#define MTL_DMC_PATH                        DMC_LEGACY_PATH(mtl, 2, 22)

This will not work because the blob is under "intel-ci/".

Better to use the path directly here, i.e.,
"intel-ci/i915/mtl_dmc_ver2_22.bin".

--
Gustavo Sousa

> MODULE_FIRMWARE(MTL_DMC_PATH);
> 
> #define DG2_DMC_PATH                        DMC_LEGACY_PATH(dg2, 2, 08)
>-- 
>2.34.1
>
Dnyaneshwar Bhadane July 29, 2024, 8:33 p.m. UTC | #2
> -----Original Message-----
> From: Sousa, Gustavo <gustavo.sousa@intel.com>
> Sent: Tuesday, July 30, 2024 1:44 AM
> To: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@intel.com>
> Subject: Re: [PATCH] [CI] drm/i915/dmc: Hardcode path to MTL DMC v2.22
> 
> Quoting Dnyaneshwar Bhadane (2024-07-29 17:04:41-03:00)
> >NOT TO BE REVIEWED/MERGED
> >Hardcode path to DMC firmware for CI purposes only.
> >
> >Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> >---
> > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> >b/drivers/gpu/drm/i915/display/intel_dmc.c
> >index 73977b173898..5ef22a76c11e 100644
> >--- a/drivers/gpu/drm/i915/display/intel_dmc.c
> >+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> >@@ -119,7 +119,7 @@ MODULE_FIRMWARE(XE2LPD_DMC_PATH);
> > #define BMG_DMC_PATH                        DMC_PATH(bmg)
> > MODULE_FIRMWARE(BMG_DMC_PATH);
> >
> >-#define MTL_DMC_PATH                        DMC_PATH(mtl)
> >+#define MTL_DMC_PATH                        DMC_LEGACY_PATH(mtl, 2, 22)
> 
> This will not work because the blob is under "intel-ci/".
> 
> Better to use the path directly here, i.e., "intel-ci/i915/mtl_dmc_ver2_22.bin".
Thank you Gustavo, Updated the path in V2.
Dnyaneshwar
> 
> --
> Gustavo Sousa
> 
> > MODULE_FIRMWARE(MTL_DMC_PATH);
> >
> > #define DG2_DMC_PATH                        DMC_LEGACY_PATH(dg2, 2, 08)
> >--
> >2.34.1
> >
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 73977b173898..5ef22a76c11e 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -119,7 +119,7 @@  MODULE_FIRMWARE(XE2LPD_DMC_PATH);
 #define BMG_DMC_PATH			DMC_PATH(bmg)
 MODULE_FIRMWARE(BMG_DMC_PATH);
 
-#define MTL_DMC_PATH			DMC_PATH(mtl)
+#define MTL_DMC_PATH			DMC_LEGACY_PATH(mtl, 2, 22)
 MODULE_FIRMWARE(MTL_DMC_PATH);
 
 #define DG2_DMC_PATH			DMC_LEGACY_PATH(dg2, 2, 08)