| Message ID | 20240731122311.1143153-10-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Use backlight power constants | expand |
Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Jyri Sarha <jyri.sarha@iki.fi> > Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index 68093d6b6b16..5f2d1b6f9ee9 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -49,7 +49,7 @@ static void panel_encoder_dpms(struct drm_encoder *encoder, int mode) > > if (backlight) { > backlight->props.power = mode == DRM_MODE_DPMS_ON ? > - FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN; > + BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; > backlight_update_status(backlight); > } >
Hi, On 15/08/2024 10:59, Thomas Zimmermann wrote: > Ping. This patch still needs an ack. > > Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: >> Replace FB_BLANK_ constants with their counterparts from the >> backlight subsystem. The values are identical, so there's no >> change in functionality or semantics. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Jyri Sarha <jyri.sarha@iki.fi> >> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> >> --- >> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/ >> tilcdc/tilcdc_panel.c >> index 68093d6b6b16..5f2d1b6f9ee9 100644 >> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c >> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c >> @@ -49,7 +49,7 @@ static void panel_encoder_dpms(struct drm_encoder >> *encoder, int mode) >> if (backlight) { >> backlight->props.power = mode == DRM_MODE_DPMS_ON ? >> - FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN; >> + BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; >> backlight_update_status(backlight); >> } > Jyri acked it a few weeks ago. But in addition: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Tomi
Am 15.08.24 um 10:07 schrieb Tomi Valkeinen: > Hi, > > On 15/08/2024 10:59, Thomas Zimmermann wrote: >> Ping. This patch still needs an ack. >> >> Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: >>> Replace FB_BLANK_ constants with their counterparts from the >>> backlight subsystem. The values are identical, so there's no >>> change in functionality or semantics. >>> >>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >>> Cc: Jyri Sarha <jyri.sarha@iki.fi> >>> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> >>> --- >>> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c >>> b/drivers/gpu/drm/ tilcdc/tilcdc_panel.c >>> index 68093d6b6b16..5f2d1b6f9ee9 100644 >>> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c >>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c >>> @@ -49,7 +49,7 @@ static void panel_encoder_dpms(struct drm_encoder >>> *encoder, int mode) >>> if (backlight) { >>> backlight->props.power = mode == DRM_MODE_DPMS_ON ? >>> - FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN; >>> + BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; >>> backlight_update_status(backlight); >>> } >> > > Jyri acked it a few weeks ago. But in addition: Oh, I didn't see that. Sorry. > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Thanks Best regards Thomas > > Tomi >
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index 68093d6b6b16..5f2d1b6f9ee9 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c @@ -49,7 +49,7 @@ static void panel_encoder_dpms(struct drm_encoder *encoder, int mode) if (backlight) { backlight->props.power = mode == DRM_MODE_DPMS_ON ? - FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN; + BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; backlight_update_status(backlight); }
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Jyri Sarha <jyri.sarha@iki.fi> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)