| Message ID | 20240731122311.1143153-7-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Use backlight power constants | expand |
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: > Replace FB_BLANK_ constants with their counterparts from the > backlight subsystem. The values are identical, so there's no > change in functionality or semantics. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Jessica Zhang <quic_jesszhan@quicinc.com> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > index 639a4fdf57bb..ab8b58545284 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c > @@ -458,7 +458,7 @@ static int s6e3ha2_set_brightness(struct backlight_device *bl_dev) > return -EINVAL; > } > > - if (bl_dev->props.power > FB_BLANK_NORMAL) > + if (bl_dev->props.power > BACKLIGHT_POWER_REDUCED) > return -EPERM; > > s6e3ha2_call_write_func(ret, s6e3ha2_test_key_on_f0(ctx)); > @@ -508,7 +508,7 @@ static int s6e3ha2_disable(struct drm_panel *panel) > s6e3ha2_call_write_func(ret, mipi_dsi_dcs_set_display_off(dsi)); > > msleep(40); > - ctx->bl_dev->props.power = FB_BLANK_NORMAL; > + ctx->bl_dev->props.power = BACKLIGHT_POWER_REDUCED; > > return 0; > } > @@ -554,7 +554,7 @@ static int s6e3ha2_prepare(struct drm_panel *panel) > if (ret < 0) > goto err; > > - ctx->bl_dev->props.power = FB_BLANK_NORMAL; > + ctx->bl_dev->props.power = BACKLIGHT_POWER_REDUCED; > > return 0; > > @@ -601,7 +601,7 @@ static int s6e3ha2_enable(struct drm_panel *panel) > s6e3ha2_call_write_func(ret, s6e3ha2_test_key_off_f0(ctx)); > > s6e3ha2_call_write_func(ret, mipi_dsi_dcs_set_display_on(dsi)); > - ctx->bl_dev->props.power = FB_BLANK_UNBLANK; > + ctx->bl_dev->props.power = BACKLIGHT_POWER_ON; > > return 0; > } > @@ -729,7 +729,7 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi) > > ctx->bl_dev->props.max_brightness = S6E3HA2_MAX_BRIGHTNESS; > ctx->bl_dev->props.brightness = S6E3HA2_DEFAULT_BRIGHTNESS; > - ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; > + ctx->bl_dev->props.power = BACKLIGHT_POWER_OFF; > > drm_panel_init(&ctx->panel, dev, &s6e3ha2_drm_funcs, > DRM_MODE_CONNECTOR_DSI); > -- > 2.45.2 >
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c index 639a4fdf57bb..ab8b58545284 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c @@ -458,7 +458,7 @@ static int s6e3ha2_set_brightness(struct backlight_device *bl_dev) return -EINVAL; } - if (bl_dev->props.power > FB_BLANK_NORMAL) + if (bl_dev->props.power > BACKLIGHT_POWER_REDUCED) return -EPERM; s6e3ha2_call_write_func(ret, s6e3ha2_test_key_on_f0(ctx)); @@ -508,7 +508,7 @@ static int s6e3ha2_disable(struct drm_panel *panel) s6e3ha2_call_write_func(ret, mipi_dsi_dcs_set_display_off(dsi)); msleep(40); - ctx->bl_dev->props.power = FB_BLANK_NORMAL; + ctx->bl_dev->props.power = BACKLIGHT_POWER_REDUCED; return 0; } @@ -554,7 +554,7 @@ static int s6e3ha2_prepare(struct drm_panel *panel) if (ret < 0) goto err; - ctx->bl_dev->props.power = FB_BLANK_NORMAL; + ctx->bl_dev->props.power = BACKLIGHT_POWER_REDUCED; return 0; @@ -601,7 +601,7 @@ static int s6e3ha2_enable(struct drm_panel *panel) s6e3ha2_call_write_func(ret, s6e3ha2_test_key_off_f0(ctx)); s6e3ha2_call_write_func(ret, mipi_dsi_dcs_set_display_on(dsi)); - ctx->bl_dev->props.power = FB_BLANK_UNBLANK; + ctx->bl_dev->props.power = BACKLIGHT_POWER_ON; return 0; } @@ -729,7 +729,7 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi) ctx->bl_dev->props.max_brightness = S6E3HA2_MAX_BRIGHTNESS; ctx->bl_dev->props.brightness = S6E3HA2_DEFAULT_BRIGHTNESS; - ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; + ctx->bl_dev->props.power = BACKLIGHT_POWER_OFF; drm_panel_init(&ctx->panel, dev, &s6e3ha2_drm_funcs, DRM_MODE_CONNECTOR_DSI);
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Jessica Zhang <quic_jesszhan@quicinc.com> --- drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)