| Message ID | 20240816125408.310253-32-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Provide client setup helper and convert drivers | expand |
On 16/08/2024 14:22, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > index 775d5d5e828c..0ef9f7b59ccb 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > @@ -31,6 +31,7 @@ > #include <video/mipi_display.h> > > #include <drm/drm_atomic_helper.h> > +#include <drm/drm_client_setup.h> > #include <drm/drm_drv.h> > #include <drm/drm_fbdev_dma.h> > #include <drm/drm_gem_atomic_helper.h> > @@ -591,6 +592,7 @@ static struct drm_driver ili9341_dbi_driver = { > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > .fops = &ili9341_dbi_fops, > DRM_GEM_DMA_DRIVER_OPS_VMAP, > + DRM_FBDEV_DMA_DRIVER_OPS, > .debugfs_init = mipi_dbi_debugfs_init, > .name = "ili9341", > .desc = "Ilitek ILI9341", > @@ -651,7 +653,7 @@ static int ili9341_dbi_probe(struct spi_device *spi, struct gpio_desc *dc, > > spi_set_drvdata(spi, drm); > > - drm_fbdev_dma_setup(drm, 0); > + drm_client_setup(drm, NULL); > > return 0; > } Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 16/08/2024 14:22, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > index 775d5d5e828c..0ef9f7b59ccb 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c > @@ -31,6 +31,7 @@ > #include <video/mipi_display.h> > > #include <drm/drm_atomic_helper.h> > +#include <drm/drm_client_setup.h> > #include <drm/drm_drv.h> > #include <drm/drm_fbdev_dma.h> > #include <drm/drm_gem_atomic_helper.h> > @@ -591,6 +592,7 @@ static struct drm_driver ili9341_dbi_driver = { > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > .fops = &ili9341_dbi_fops, > DRM_GEM_DMA_DRIVER_OPS_VMAP, > + DRM_FBDEV_DMA_DRIVER_OPS, > .debugfs_init = mipi_dbi_debugfs_init, > .name = "ili9341", > .desc = "Ilitek ILI9341", > @@ -651,7 +653,7 @@ static int ili9341_dbi_probe(struct spi_device *spi, struct gpio_desc *dc, > > spi_set_drvdata(spi, drm); > > - drm_fbdev_dma_setup(drm, 0); > + drm_client_setup(drm, NULL); > > return 0; > } So which one is right, this one or : https://lore.kernel.org/all/20240813091258.1625646-1-andriy.shevchenko@linux.intel.com/ ? Neil
Hi Am 19.08.24 um 17:39 schrieb Neil Armstrong: > On 16/08/2024 14:22, Thomas Zimmermann wrote: >> Call drm_client_setup() to run the kernel's default client setup >> for DRM. Set fbdev_probe in struct drm_driver, so that the client >> setup can start the common fbdev client. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Cc: Neil Armstrong <neil.armstrong@linaro.org> >> Cc: Jessica Zhang <quic_jesszhan@quicinc.com> >> --- >> drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c >> b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c >> index 775d5d5e828c..0ef9f7b59ccb 100644 >> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c >> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c >> @@ -31,6 +31,7 @@ >> #include <video/mipi_display.h> >> #include <drm/drm_atomic_helper.h> >> +#include <drm/drm_client_setup.h> >> #include <drm/drm_drv.h> >> #include <drm/drm_fbdev_dma.h> >> #include <drm/drm_gem_atomic_helper.h> >> @@ -591,6 +592,7 @@ static struct drm_driver ili9341_dbi_driver = { >> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, >> .fops = &ili9341_dbi_fops, >> DRM_GEM_DMA_DRIVER_OPS_VMAP, >> + DRM_FBDEV_DMA_DRIVER_OPS, >> .debugfs_init = mipi_dbi_debugfs_init, >> .name = "ili9341", >> .desc = "Ilitek ILI9341", >> @@ -651,7 +653,7 @@ static int ili9341_dbi_probe(struct spi_device >> *spi, struct gpio_desc *dc, >> spi_set_drvdata(spi, drm); >> - drm_fbdev_dma_setup(drm, 0); >> + drm_client_setup(drm, NULL); >> return 0; >> } > > So which one is right, this one or : > https://lore.kernel.org/all/20240813091258.1625646-1-andriy.shevchenko@linux.intel.com/ > > ? There's long been talk about removing some duplicated drivers. IDK which is the correct or best one. I'll patch the panel driver if it will still be there. Best regards Thomas > > Neil
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 775d5d5e828c..0ef9f7b59ccb 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -31,6 +31,7 @@ #include <video/mipi_display.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_client_setup.h> #include <drm/drm_drv.h> #include <drm/drm_fbdev_dma.h> #include <drm/drm_gem_atomic_helper.h> @@ -591,6 +592,7 @@ static struct drm_driver ili9341_dbi_driver = { .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, .fops = &ili9341_dbi_fops, DRM_GEM_DMA_DRIVER_OPS_VMAP, + DRM_FBDEV_DMA_DRIVER_OPS, .debugfs_init = mipi_dbi_debugfs_init, .name = "ili9341", .desc = "Ilitek ILI9341", @@ -651,7 +653,7 @@ static int ili9341_dbi_probe(struct spi_device *spi, struct gpio_desc *dc, spi_set_drvdata(spi, drm); - drm_fbdev_dma_setup(drm, 0); + drm_client_setup(drm, NULL); return 0; }
Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Jessica Zhang <quic_jesszhan@quicinc.com> --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)