| Message ID | 20240827140353.3022432-1-dnyaneshwar.bhadane@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/dmc: Hardcode path to MTL DMC v2.23 | expand |
On Tue, 27 Aug 2024, Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> wrote: > NOT TO BE REVIEWED/MERGED > Hardcode path to DMC firmware for CI purposes only. This is why we have trybot, no? BR, Jani. > > Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c > index 7c756d5ba2a2..723743cbe8e2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dmc.c > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c > @@ -119,7 +119,7 @@ MODULE_FIRMWARE(XE2LPD_DMC_PATH); > #define BMG_DMC_PATH DMC_PATH(bmg) > MODULE_FIRMWARE(BMG_DMC_PATH); > > -#define MTL_DMC_PATH DMC_PATH(mtl) > +#define MTL_DMC_PATH "i915/mtl_dmc_ver2_23.bin" > MODULE_FIRMWARE(MTL_DMC_PATH); > > #define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
Quoting Jani Nikula (2024-08-28 05:42:01-03:00) >On Tue, 27 Aug 2024, Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> wrote: >> NOT TO BE REVIEWED/MERGED >> Hardcode path to DMC firmware for CI purposes only. > >This is why we have trybot, no? This patch is not an "experimentation" type of thing, it is part of our regular process of releasing DMC blobs: we make the firmware available publicly and then send a patch like this one to test it using the regular full CI cycle before sending an official pull request to linux-firmware. As such, I believe it should be treated as a "regular patch" from the CI perspective, even though it is not intended to be merged. (By the way, "[CI]" as prefix for the subject would be suitable here). -- Gustavo Sousa
> -----Original Message----- > From: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@intel.com> > Sent: Tuesday, August 27, 2024 7:34 PM > To: intel-gfx@lists.freedesktop.org > Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@intel.com> > Subject: [PATCH] drm/i915/dmc: Hardcode path to MTL DMC v2.23 > > NOT TO BE REVIEWED/MERGED > Hardcode path to DMC firmware for CI purposes only. > > Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> The regression issue kms_psr2_sf test failure observed in mtl dmc v2.22 is now passed with mtl dmc v2.23. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137842v1/shards-all.html?testfilter=kms_psr2_sf DMC FW loaded successfully : https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137842v1/index.html?testfilter=module_load > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c > b/drivers/gpu/drm/i915/display/intel_dmc.c > index 7c756d5ba2a2..723743cbe8e2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dmc.c > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c > @@ -119,7 +119,7 @@ MODULE_FIRMWARE(XE2LPD_DMC_PATH); > #define BMG_DMC_PATH DMC_PATH(bmg) > MODULE_FIRMWARE(BMG_DMC_PATH); > > -#define MTL_DMC_PATH DMC_PATH(mtl) > +#define MTL_DMC_PATH "i915/mtl_dmc_ver2_23.bin" > MODULE_FIRMWARE(MTL_DMC_PATH); > > #define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08) > -- > 2.34.1
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index 7c756d5ba2a2..723743cbe8e2 100644 --- a/drivers/gpu/drm/i915/display/intel_dmc.c +++ b/drivers/gpu/drm/i915/display/intel_dmc.c @@ -119,7 +119,7 @@ MODULE_FIRMWARE(XE2LPD_DMC_PATH); #define BMG_DMC_PATH DMC_PATH(bmg) MODULE_FIRMWARE(BMG_DMC_PATH); -#define MTL_DMC_PATH DMC_PATH(mtl) +#define MTL_DMC_PATH "i915/mtl_dmc_ver2_23.bin" MODULE_FIRMWARE(MTL_DMC_PATH); #define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
NOT TO BE REVIEWED/MERGED Hardcode path to DMC firmware for CI purposes only. Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)