| Message ID | 20240904101834.2415385-3-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DP2.1 Panel Replay Fixes | expand |
On Wed, Sep 04, 2024 at 01:18:33PM +0300, Jouni Högander wrote: > Connector debugfs files are currently not add for MST connector. We > can now add them as we have taken into account possibility to have > NULL in connector->encoder in intel_attached_dp. > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 257526362b39a..26af8bea05d32 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -3799,9 +3799,8 @@ void intel_psr_connector_debugfs_add(struct intel_connector *connector) > struct dentry *root = connector->base.debugfs_entry; > > /* TODO: Add support for MST connectors as well. */ > - if ((connector->base.connector_type != DRM_MODE_CONNECTOR_eDP && > - connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort) || > - connector->mst_port) > + if (connector->base.connector_type != DRM_MODE_CONNECTOR_eDP && > + connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort) Looks ok: Reviewed-by: Imre Deak <imre.deak@intel.com> The TODO: comment above could be also removed. > return; > > debugfs_create_file("i915_psr_sink_status", 0444, root, > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 257526362b39a..26af8bea05d32 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -3799,9 +3799,8 @@ void intel_psr_connector_debugfs_add(struct intel_connector *connector) struct dentry *root = connector->base.debugfs_entry; /* TODO: Add support for MST connectors as well. */ - if ((connector->base.connector_type != DRM_MODE_CONNECTOR_eDP && - connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort) || - connector->mst_port) + if (connector->base.connector_type != DRM_MODE_CONNECTOR_eDP && + connector->base.connector_type != DRM_MODE_CONNECTOR_DisplayPort) return; debugfs_create_file("i915_psr_sink_status", 0444, root,
Connector debugfs files are currently not add for MST connector. We can now add them as we have taken into account possibility to have NULL in connector->encoder in intel_attached_dp. Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_psr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)