diff mbox series

[1/6] drm/i915/cdclk: Add missing braces

Message ID 20240906143306.15937-2-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Some intel_display conversions | expand

Commit Message

Ville Syrjälä Sept. 6, 2024, 2:33 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

CodingStyle says when one branch of an if ladder is braced
then all of them should be. Make it so.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cdclk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rodrigo Vivi Sept. 6, 2024, 3:10 p.m. UTC | #1 
On Fri, Sep 06, 2024 at 05:33:01PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> CodingStyle says when one branch of an if ladder is braced
> then all of them should be. Make it so.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_cdclk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 66964c7d2a2c..9d870d15d888 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -2053,8 +2053,9 @@ static void _bxt_set_cdclk(struct drm_i915_private *dev_priv,
>  			dg2_cdclk_squash_program(dev_priv, 0);
>  
>  		icl_cdclk_pll_update(dev_priv, vco);
> -	} else
> +	} else {
>  		bxt_cdclk_pll_update(dev_priv, vco);
> +	}
>  
>  	if (HAS_CDCLK_SQUASH(dev_priv)) {
>  		u16 waveform = cdclk_squash_waveform(dev_priv, cdclk);
> -- 
> 2.44.2
>
Jani Nikula Sept. 6, 2024, 3:19 p.m. UTC | #2 
On Fri, 06 Sep 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> CodingStyle says when one branch of an if ladder is braced
> then all of them should be. Make it so.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_cdclk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 66964c7d2a2c..9d870d15d888 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -2053,8 +2053,9 @@ static void _bxt_set_cdclk(struct drm_i915_private *dev_priv,
>  			dg2_cdclk_squash_program(dev_priv, 0);
>  
>  		icl_cdclk_pll_update(dev_priv, vco);
> -	} else
> +	} else {
>  		bxt_cdclk_pll_update(dev_priv, vco);
> +	}
>  
>  	if (HAS_CDCLK_SQUASH(dev_priv)) {
>  		u16 waveform = cdclk_squash_waveform(dev_priv, cdclk);
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 66964c7d2a2c..9d870d15d888 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -2053,8 +2053,9 @@  static void _bxt_set_cdclk(struct drm_i915_private *dev_priv,
 			dg2_cdclk_squash_program(dev_priv, 0);
 
 		icl_cdclk_pll_update(dev_priv, vco);
-	} else
+	} else {
 		bxt_cdclk_pll_update(dev_priv, vco);
+	}
 
 	if (HAS_CDCLK_SQUASH(dev_priv)) {
 		u16 waveform = cdclk_squash_waveform(dev_priv, cdclk);