diff mbox series

drm/i915/pciid: Add new PCI id for ARL

Message ID 20240910062301.2006782-1-dnyaneshwar.bhadane@intel.com (mailing list archive)
State New
Headers show
Series drm/i915/pciid: Add new PCI id for ARL | expand

Commit Message

Dnyaneshwar Bhadane Sept. 10, 2024, 6:23 a.m. UTC
Add new PCI id for ARL platform.

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
 include/drm/intel/i915_pciids.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Nemesa Garg Sept. 10, 2024, 7:46 a.m. UTC | #1
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Dnyaneshwar Bhadane
> Sent: Tuesday, September 10, 2024 11:53 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane@intel.com>
> Subject: [PATCH] drm/i915/pciid: Add new PCI id for ARL
> 
> Add new PCI id for ARL platform.
> 
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Reviewed-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
>  include/drm/intel/i915_pciids.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/intel/i915_pciids.h b/include/drm/intel/i915_pciids.h
> index cbb12fdbcb7f..02156c6f79b6 100644
> --- a/include/drm/intel/i915_pciids.h
> +++ b/include/drm/intel/i915_pciids.h
> @@ -769,7 +769,8 @@
>  	MACRO__(0x7D41, ## __VA_ARGS__), \
>  	MACRO__(0x7D51, ## __VA_ARGS__), \
>  	MACRO__(0x7D67, ## __VA_ARGS__), \
> -	MACRO__(0x7DD1, ## __VA_ARGS__)
> +	MACRO__(0x7DD1, ## __VA_ARGS__), \
> +	MACRO__(0xB640, ## __VA_ARGS__)
> LGTM
>  /* MTL */
>  #define INTEL_MTL_IDS(MACRO__, ...) \
> --
> 2.34.1
Pottumuttu, Sai Teja Sept. 10, 2024, 7:59 a.m. UTC | #2
On 10-09-2024 11:53, Dnyaneshwar Bhadane wrote:
> Add new PCI id for ARL platform.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

I assume that you would send another patch to sync this PCI ID addition 
in xe_pciids.h as well

With that,

Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>

> ---
>   include/drm/intel/i915_pciids.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/intel/i915_pciids.h b/include/drm/intel/i915_pciids.h
> index cbb12fdbcb7f..02156c6f79b6 100644
> --- a/include/drm/intel/i915_pciids.h
> +++ b/include/drm/intel/i915_pciids.h
> @@ -769,7 +769,8 @@
>   	MACRO__(0x7D41, ## __VA_ARGS__), \
>   	MACRO__(0x7D51, ## __VA_ARGS__), \
>   	MACRO__(0x7D67, ## __VA_ARGS__), \
> -	MACRO__(0x7DD1, ## __VA_ARGS__)
> +	MACRO__(0x7DD1, ## __VA_ARGS__), \
> +	MACRO__(0xB640, ## __VA_ARGS__)
>   
>   /* MTL */
>   #define INTEL_MTL_IDS(MACRO__, ...) \
Jani Nikula Sept. 10, 2024, 10:21 a.m. UTC | #3
On Tue, 10 Sep 2024, "Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com> wrote:
> On 10-09-2024 11:53, Dnyaneshwar Bhadane wrote:
>> Add new PCI id for ARL platform.
>>
>> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>
> I assume that you would send another patch to sync this PCI ID addition 
> in xe_pciids.h as well

Yes, preferrably send both at the same time, even though one is to be
merged to drm-intel-next and the other to drm-xe-next. We don't want the
PCI IDs to be out of sync.

Lucas, Rodrigo, another reason for [1].

BR,
Jani.


[1] https://lore.kernel.org/r/5e703ab69846d519335f3e7f5bcf84ff1704cd09.1725297097.git.jani.nikula@intel.com


>
> With that,
>
> Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
>
>> ---
>>   include/drm/intel/i915_pciids.h | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/drm/intel/i915_pciids.h b/include/drm/intel/i915_pciids.h
>> index cbb12fdbcb7f..02156c6f79b6 100644
>> --- a/include/drm/intel/i915_pciids.h
>> +++ b/include/drm/intel/i915_pciids.h
>> @@ -769,7 +769,8 @@
>>   	MACRO__(0x7D41, ## __VA_ARGS__), \
>>   	MACRO__(0x7D51, ## __VA_ARGS__), \
>>   	MACRO__(0x7D67, ## __VA_ARGS__), \
>> -	MACRO__(0x7DD1, ## __VA_ARGS__)
>> +	MACRO__(0x7DD1, ## __VA_ARGS__), \
>> +	MACRO__(0xB640, ## __VA_ARGS__)
>>   
>>   /* MTL */
>>   #define INTEL_MTL_IDS(MACRO__, ...) \
diff mbox series

Patch

diff --git a/include/drm/intel/i915_pciids.h b/include/drm/intel/i915_pciids.h
index cbb12fdbcb7f..02156c6f79b6 100644
--- a/include/drm/intel/i915_pciids.h
+++ b/include/drm/intel/i915_pciids.h
@@ -769,7 +769,8 @@ 
 	MACRO__(0x7D41, ## __VA_ARGS__), \
 	MACRO__(0x7D51, ## __VA_ARGS__), \
 	MACRO__(0x7D67, ## __VA_ARGS__), \
-	MACRO__(0x7DD1, ## __VA_ARGS__)
+	MACRO__(0x7DD1, ## __VA_ARGS__), \
+	MACRO__(0xB640, ## __VA_ARGS__)
 
 /* MTL */
 #define INTEL_MTL_IDS(MACRO__, ...) \