| Message ID | 20240924204222.246862-28-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Reconcile i915's and xe's display power mgt sequences | expand |
-----Original Message----- From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org Cc: Deak, Imre <imre.deak@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com> Subject: [PATCH 27/31] drm/xe/display: Notify opregion upon runtime suspend/resume non-d3cold > > Opregion needs to be notified about the power transition even when > not going to d3cold. This aligns with i915 sequence. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> LGTM. Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> -Jonathan Cavitt > --- > drivers/gpu/drm/xe/display/xe_display.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index 44cace0237dd..780c8d7f392d 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -447,6 +447,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe) > > if (xe->d3cold.allowed) > intel_display_power_suspend_late(xe, false); > + else > + intel_opregion_notify_adapter(&xe->display, PCI_D1); > > intel_hpd_poll_enable(xe); > } > @@ -458,6 +460,8 @@ void xe_display_pm_runtime_resume_early(struct xe_device *xe) > > if (xe->d3cold.allowed) > intel_display_power_resume_early(xe); > + else > + intel_opregion_notify_adapter(&xe->display, PCI_D0); > } > > void xe_display_pm_runtime_resume(struct xe_device *xe) > -- > 2.46.0 > >
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c index 44cace0237dd..780c8d7f392d 100644 --- a/drivers/gpu/drm/xe/display/xe_display.c +++ b/drivers/gpu/drm/xe/display/xe_display.c @@ -447,6 +447,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe) if (xe->d3cold.allowed) intel_display_power_suspend_late(xe, false); + else + intel_opregion_notify_adapter(&xe->display, PCI_D1); intel_hpd_poll_enable(xe); } @@ -458,6 +460,8 @@ void xe_display_pm_runtime_resume_early(struct xe_device *xe) if (xe->d3cold.allowed) intel_display_power_resume_early(xe); + else + intel_opregion_notify_adapter(&xe->display, PCI_D0); } void xe_display_pm_runtime_resume(struct xe_device *xe)
Opregion needs to be notified about the power transition even when not going to d3cold. This aligns with i915 sequence. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/xe/display/xe_display.c | 4 ++++ 1 file changed, 4 insertions(+)