| Message ID | 20241025060136.9884-4-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add 6k resolution support for a single CRTC | expand |
On Fri, Oct 25, 2024 at 11:31:34AM +0530, Suraj Kandpal wrote: > Increase the psr max_h limit to 4096. Commit message doesn't match code (this should probably say max_v instead of max_h). Since PSR2 size is supported up to the maximum pipe size now (for both Xe2 and Xe3) would it be simpler to just make the check on psr_max_{h,v} conditional to pre-Xe2? Then if we don't have any truly PSR-specific limits, we don't need to keep duplicating the pipe limits in two places going forward. Matt > > Bspec: 69885, 68858 > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 4176163ec19a..c22386a31a63 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1453,7 +1453,11 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp, > return false; > } > > - if (DISPLAY_VER(display) >= 12) { > + if (DISPLAY_VER(display) >= 20) { > + psr_max_h = 5120; > + psr_max_v = 4096; > + max_bpp = 30; > + } else if (DISPLAY_VER(display) >= 12) { > psr_max_h = 5120; > psr_max_v = 3200; > max_bpp = 30; > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 4176163ec19a..c22386a31a63 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -1453,7 +1453,11 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp, return false; } - if (DISPLAY_VER(display) >= 12) { + if (DISPLAY_VER(display) >= 20) { + psr_max_h = 5120; + psr_max_v = 4096; + max_bpp = 30; + } else if (DISPLAY_VER(display) >= 12) { psr_max_h = 5120; psr_max_v = 3200; max_bpp = 30;
Increase the psr max_h limit to 4096. Bspec: 69885, 68858 Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_psr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)