From patchwork Tue Nov 12 08:45:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Kandpal X-Patchwork-Id: 13871918 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3849DD41D70 for ; Tue, 12 Nov 2024 08:45:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD3CE10E275; Tue, 12 Nov 2024 08:45:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="m8oisyX1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 992F610E02B; Tue, 12 Nov 2024 08:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731401153; x=1762937153; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ZcgpnOa40SIuetdynEKEerOPih2ow/d+dMCvF24+4HA=; b=m8oisyX1xYZWxZ/orPCJclq+20e98Cd/gIaR0EpLfdjSJH6o6BvUOVOz 44m4+/luROlRaQfuOgD1s5wi4pT88pl5h+wGAb3fG6jZkoGjcZfYWNpT9 i+3kLeCQb7XsiiXPnRWYgrl8eVyPhADSmdfU4SLXE0ZH3BuE78+4DzQrJ 1rgeG+eOMCDQbctWpL0CFisVSi6HFb7AGL2qOkQv6JKBX1FOV3mklQUlo 5jKIhg8cJF0W+Aofhj2IYHslGqFLuZCVhLPSKO3xn5YOJrrUnzv+vMSXm 0czHwlELef08jDrxYEkts9YLiXzJlNGiriGdHp/3OtxzKSKjXoiGwOjER A==; X-CSE-ConnectionGUID: o0yowKCvQoOgSIE/4BOR+Q== X-CSE-MsgGUID: NYfSSGvMQHCCsuYO6r8Edw== X-IronPort-AV: E=McAfee;i="6700,10204,11253"; a="31449603" X-IronPort-AV: E=Sophos;i="6.12,147,1728975600"; d="scan'208";a="31449603" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2024 00:45:53 -0800 X-CSE-ConnectionGUID: GL6Ma1GIQiGilu/k3AFw7w== X-CSE-MsgGUID: QiF0dTe8Svi2yOhfxniUCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,147,1728975600"; d="scan'208";a="124851940" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa001.jf.intel.com with ESMTP; 12 Nov 2024 00:45:52 -0800 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: vinod.govindapillai@intel.com, ville.syrjala@intel.com, Suraj Kandpal , Mitul Golani Subject: [PATCH 1/6] drm/i915/watermark: Initialize latency variable to appropriate value Date: Tue, 12 Nov 2024 14:15:37 +0530 Message-Id: <20241112084542.1337314-1-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Initialize max_latency variable to LNL_PKG_C_LATENCY_MASK which helps to eliminate the else block and make the whole code a lot cleaner. Signed-off-by: Suraj Kandpal Reviewed-by: Mitul Golani --- drivers/gpu/drm/i915/display/skl_watermark.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c index d3bbf335c749..a97e90ac643f 100644 --- a/drivers/gpu/drm/i915/display/skl_watermark.c +++ b/drivers/gpu/drm/i915/display/skl_watermark.c @@ -2850,7 +2850,7 @@ static int skl_wm_add_affected_planes(struct intel_atomic_state *state, static void skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc) { - u32 max_latency = 0; + u32 max_latency = LNL_PKG_C_LATENCY_MASK; u32 clear = 0, val = 0; u32 added_wake_time = 0; @@ -2863,9 +2863,6 @@ skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc) max_latency = LNL_PKG_C_LATENCY_MASK; added_wake_time = DSB_EXE_TIME + i915->display.sagv.block_time_us; - } else { - max_latency = LNL_PKG_C_LATENCY_MASK; - added_wake_time = 0; } clear |= LNL_ADDED_WAKE_TIME_MASK | LNL_PKG_C_LATENCY_MASK;