From patchwork Mon Nov 18 07:53:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Murthy, Arun R" X-Patchwork-Id: 13878227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96F5DD43FE6 for ; Mon, 18 Nov 2024 08:02:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CE0B10E442; Mon, 18 Nov 2024 08:02:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bWyJLyIH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B1A210E42E; Mon, 18 Nov 2024 08:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731916977; x=1763452977; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=G6ECyqjjk4V0sKr0QYDjsTmoUzhfYUL2k9lBBrGiaTE=; b=bWyJLyIHdlSWFPCAe514p0QlV7FpCp5y94R/4AESWq5mQSSS+eU625e4 WI7bD7fSFTWOfdunfpRgj8BgvAttBKaN2NaVYBfypcUAaReibb4TNfJ3j xsNNQtmgyNToqm6PbtjSX/nDglDbIxPqBENw03B4Xd403jyFRRzcoYYXN s2HfAHuaqqz4Jh6vnq8f+UQ/I+tSkgF8FII2VwtBFxrvu6H6veAfVtQ7b YtKcO8NfJuP4qTE2Av22AjQrVZyYb98bfBO7fnJOLgYDCdkx4N0AMfguP HSgWFVTHQKPnzBrJj9Tl08uihcWkywK2VWQhMlyS68FcOEIPCjHReHQPM A==; X-CSE-ConnectionGUID: Wr7tPcydSOWP+d3xTZenHw== X-CSE-MsgGUID: UAhykkw2RSGx+8tBTXaDSQ== X-IronPort-AV: E=McAfee;i="6700,10204,11259"; a="31915486" X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="31915486" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 00:02:57 -0800 X-CSE-ConnectionGUID: H1fap+UVSiWIXnO9es9ObA== X-CSE-MsgGUID: Qcw0CPrIQjeaLyKCOnAATQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="89061836" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orviesa010.jf.intel.com with ESMTP; 18 Nov 2024 00:02:54 -0800 From: Arun R Murthy To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Arun R Murthy Subject: [PATCHv2 2/3] drm/plane: Expose function to create format/modifier blob Date: Mon, 18 Nov 2024 13:23:14 +0530 Message-Id: <20241118075315.466009-3-arun.r.murthy@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241118075315.466009-1-arun.r.murthy@intel.com> References: <20241118075315.466009-1-arun.r.murthy@intel.com> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Expose drm plane function to create formats/modifiers blob. This function can be used to expose list of supported formats/modifiers for sync/async flips. Signed-off-by: Arun R Murthy --- drivers/gpu/drm/drm_plane.c | 44 ++++++++++++++++++++++++------------- include/drm/drm_plane.h | 4 ++++ 2 files changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 416818e54ccf..4f35eec2b777 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -191,7 +191,10 @@ modifiers_ptr(struct drm_format_modifier_blob *blob) return (struct drm_format_modifier *)(((char *)blob) + blob->modifiers_offset); } -static int create_in_format_blob(struct drm_device *dev, struct drm_plane *plane) +int drm_plane_create_format_blob(struct drm_device *dev, + struct drm_plane *plane, u64 *modifiers, + unsigned int modifier_count, u32 *formats, + unsigned int format_count, bool is_async) { const struct drm_mode_config *config = &dev->mode_config; struct drm_property_blob *blob; @@ -200,14 +203,14 @@ static int create_in_format_blob(struct drm_device *dev, struct drm_plane *plane struct drm_format_modifier_blob *blob_data; unsigned int i, j; - formats_size = sizeof(__u32) * plane->format_count; + formats_size = sizeof(__u32) * format_count; if (WARN_ON(!formats_size)) { /* 0 formats are never expected */ return 0; } modifiers_size = - sizeof(struct drm_format_modifier) * plane->modifier_count; + sizeof(struct drm_format_modifier) * modifier_count; blob_size = sizeof(struct drm_format_modifier_blob); /* Modifiers offset is a pointer to a struct with a 64 bit field so it @@ -223,37 +226,45 @@ static int create_in_format_blob(struct drm_device *dev, struct drm_plane *plane blob_data = blob->data; blob_data->version = FORMAT_BLOB_CURRENT; - blob_data->count_formats = plane->format_count; + blob_data->count_formats = format_count; blob_data->formats_offset = sizeof(struct drm_format_modifier_blob); - blob_data->count_modifiers = plane->modifier_count; + blob_data->count_modifiers = modifier_count; blob_data->modifiers_offset = ALIGN(blob_data->formats_offset + formats_size, 8); - memcpy(formats_ptr(blob_data), plane->format_types, formats_size); + memcpy(formats_ptr(blob_data), formats, formats_size); mod = modifiers_ptr(blob_data); - for (i = 0; i < plane->modifier_count; i++) { - for (j = 0; j < plane->format_count; j++) { - if (!plane->funcs->format_mod_supported || + for (i = 0; i < modifier_count; i++) { + for (j = 0; j < format_count; j++) { + if (is_async || + !plane->funcs->format_mod_supported || plane->funcs->format_mod_supported(plane, - plane->format_types[j], - plane->modifiers[i])) { + formats[j], + modifiers[i])) { mod->formats |= 1ULL << j; } } - mod->modifier = plane->modifiers[i]; + mod->modifier = modifiers[i]; mod->offset = 0; mod->pad = 0; mod++; } - drm_object_attach_property(&plane->base, config->modifiers_property, - blob->base.id); + if (is_async) + drm_object_attach_property(&plane->base, + config->async_modifiers_property, + blob->base.id); + else + drm_object_attach_property(&plane->base, + config->modifiers_property, + blob->base.id); return 0; } +EXPORT_SYMBOL(drm_plane_create_format_blob); /** * DOC: hotspot properties @@ -476,7 +487,10 @@ static int __drm_universal_plane_init(struct drm_device *dev, } if (format_modifier_count) - create_in_format_blob(dev, plane); + drm_plane_create_format_blob(dev, plane, plane->modifiers, + format_modifier_count, + plane->format_types, format_count, + false); return 0; } diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index dd718c62ac31..3c5c2c614af8 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -988,5 +988,9 @@ int drm_plane_create_scaling_filter_property(struct drm_plane *plane, int drm_plane_add_size_hints_property(struct drm_plane *plane, const struct drm_plane_size_hint *hints, int num_hints); +int drm_plane_create_format_blob(struct drm_device *dev, + struct drm_plane *plane, u64 *modifiers, + unsigned int modifier_count, u32 *formats, + unsigned int format_count, bool is_async); #endif