diff mbox series

[5/8] drm/i915/scaler: Nuke redundant code

Message ID 20241219130827.22830-6-ville.syrjala@linux.intel.com (mailing list archive)
State New
Headers show
Series drm/i915/scaler: Scaler cleanups and tracepoints | expand

Commit Message

Ville Syrjälä Dec. 19, 2024, 1:08 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The tgl+ and mtl+ numbers in skl_scaler_max_dst_size() are
identical. Combine them to a single piece of code.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Luca Coelho Dec. 20, 2024, 8:52 a.m. UTC | #1 
On Thu, 2024-12-19 at 15:08 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> The tgl+ and mtl+ numbers in skl_scaler_max_dst_size() are
> identical. Combine them to a single piece of code.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_scaler.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
> index 0bc82a047510..cbc71e44fcbb 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -119,10 +119,7 @@ static void skl_scaler_max_dst_size(struct intel_crtc *crtc,
>  {
>  	struct intel_display *display = to_intel_display(crtc);
>  
> -	if (DISPLAY_VER(display) >= 14) {
> -		*max_w = 8192;
> -		*max_h = 8192;
> -	} else if (DISPLAY_VER(display) >= 12) {
> +	if (DISPLAY_VER(display) >= 12) {
>  		*max_w = 8192;
>  		*max_h = 8192;
>  	} else if (DISPLAY_VER(display) == 11) {

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 0bc82a047510..cbc71e44fcbb 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -119,10 +119,7 @@  static void skl_scaler_max_dst_size(struct intel_crtc *crtc,
 {
 	struct intel_display *display = to_intel_display(crtc);
 
-	if (DISPLAY_VER(display) >= 14) {
-		*max_w = 8192;
-		*max_h = 8192;
-	} else if (DISPLAY_VER(display) >= 12) {
+	if (DISPLAY_VER(display) >= 12) {
 		*max_w = 8192;
 		*max_h = 8192;
 	} else if (DISPLAY_VER(display) == 11) {