Message ID | 20250115075202.2356395-1-ranu.maurya@intel.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | drm/i915: Add Wa_22010465259 in its respective WA list | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ranu > Maurya > Sent: Wednesday, January 15, 2025 1:22 PM > To: intel-gfx@lists.freedesktop.org > Cc: Pottumuttu, Sai Teja <sai.teja.pottumuttu@intel.com>; Vivekanandan, > Balasubramani <balasubramani.vivekanandan@intel.com>; Maurya, Ranu > <ranu.maurya@intel.com> > Subject: [PATCH] drm/i915: Add Wa_22010465259 in its respective WA list > > Add Wa_22010465259 which points to an existing WA, but was missing from > the comment list. While at it, update the other WAs and their applicable > platforms as well. > > Signed-off-by: Ranu Maurya <ranu.maurya@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 570c91878189..277a4df31071 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c > @@ -691,16 +691,17 @@ static void gen12_ctx_workarounds_init(struct > intel_engine_cs *engine, > struct drm_i915_private *i915 = engine->i915; > > /* > - * Wa_1409142259:tgl,dg1,adl-p > + * Wa_1409142259:tgl,dg1,adl-p,adl-n > * Wa_1409347922:tgl,dg1,adl-p > * Wa_1409252684:tgl,dg1,adl-p > * Wa_1409217633:tgl,dg1,adl-p > * Wa_1409207793:tgl,dg1,adl-p > - * Wa_1409178076:tgl,dg1,adl-p > - * Wa_1408979724:tgl,dg1,adl-p > - * Wa_14010443199:tgl,rkl,dg1,adl-p > - * Wa_14010698770:tgl,rkl,dg1,adl-s,adl-p > - * Wa_1409342910:tgl,rkl,dg1,adl-s,adl-p > + * Wa_1409178076:tgl,dg1,adl-p,adl-n > + * Wa_1408979724:tgl,dg1,adl-p,adl-n > + * Wa_14010443199:tgl,rkl,dg1,adl-p,adl-n ^^^ Please include DG2 in above platform list. > + * Wa_14010698770:tgl,rkl,dg1,adl-s,adl-p,adl-n ^^^ Add DG2 in above list. With these changes LGTM. Reviewed-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> Regards, Dnyaneshwar > + * Wa_1409342910:tgl,rkl,dg1,adl-s,adl-p,adl-n > + * Wa_22010465259:tgl,rkl,dg1,adl-s,adl-p,adl-n > */ > wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3, > GEN12_DISABLE_CPS_AWARE_COLOR_PIPE); > -- > 2.25.1
It’s a false alarm, since the patch only modifies a few comments, and doesn't impact anything which might cause errors on EDID or FLIP
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Wednesday, January 15, 2025 2:17 PM
To: Maurya, Ranu <ranu.maurya@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ i915.CI.BAT: failure for drm/i915: Add Wa_22010465259 in its respective WA list
Patch Details
Series:
drm/i915: Add Wa_22010465259 in its respective WA list
URL:
https://patchwork.freedesktop.org/series/143546/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/index.html
CI Bug Log - changes from CI_DRM_15958 -> Patchwork_143546v1
Summary
FAILURE
Serious unknown changes coming with Patchwork_143546v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_143546v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org<mailto:I915-ci-infra@lists.freedesktop.org>) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/index.html
Participating hosts (42 -> 41)
Missing (1): fi-snb-2520m
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_143546v1:
IGT changes
Possible regressions
* igt@kms_chamelium_edid@dp-edid-read:
* bat-dg2-13: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html>
* igt@kms_flip@basic-flip-vs-modeset@b-dp1:
* bat-apl-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@b-dp1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@b-dp1.html> +3 other tests dmesg-warn
Known issues
Here are the changes found in Patchwork_143546v1 that come from known issues:
IGT changes
Issues hit
* igt@i915_pm_rpm@module-reload:
* bat-adls-6: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-adls-6/igt@i915_pm_rpm@module-reload.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-adls-6/igt@i915_pm_rpm@module-reload.html> (i915#13401<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13401>)
* bat-rpls-4: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-rpls-4/igt@i915_pm_rpm@module-reload.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html> (i915#13401<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13401>)
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
* bat-dg2-11: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html> (i915#9197<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197>) +2 other tests skip
Possible fixes
* igt@core_hotunplug@unbind-rebind:
* bat-dg2-9: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-dg2-9/igt@core_hotunplug@unbind-rebind.html> (i915#13496<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13496>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-dg2-9/igt@core_hotunplug@unbind-rebind.html>
* igt@i915_selftest@live@gt_mocs:
* bat-twl-2: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-twl-2/igt@i915_selftest@live@gt_mocs.html> (i915#12919<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-twl-2/igt@i915_selftest@live@gt_mocs.html> +1 other test pass
* igt@i915_selftest@live@workarounds:
* bat-arls-5: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15958/bat-arls-5/igt@i915_selftest@live@workarounds.html> (i915#13393<https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13393>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_143546v1/bat-arls-5/igt@i915_selftest@live@workarounds.html> +1 other test pass
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Build changes
* Linux: CI_DRM_15958 -> Patchwork_143546v1
CI-20190529: 20190529
CI_DRM_15958: ac1e97c603501be90e530b0ce0eac45728869c85 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8190: db6e252e00bc44f90b678d547e93b3f02c02c6de @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_143546v1: ac1e97c603501be90e530b0ce0eac45728869c85 @ git://anongit.freedesktop.org/gfx-ci/linux
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 570c91878189..277a4df31071 100644 --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c @@ -691,16 +691,17 @@ static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine, struct drm_i915_private *i915 = engine->i915; /* - * Wa_1409142259:tgl,dg1,adl-p + * Wa_1409142259:tgl,dg1,adl-p,adl-n * Wa_1409347922:tgl,dg1,adl-p * Wa_1409252684:tgl,dg1,adl-p * Wa_1409217633:tgl,dg1,adl-p * Wa_1409207793:tgl,dg1,adl-p - * Wa_1409178076:tgl,dg1,adl-p - * Wa_1408979724:tgl,dg1,adl-p - * Wa_14010443199:tgl,rkl,dg1,adl-p - * Wa_14010698770:tgl,rkl,dg1,adl-s,adl-p - * Wa_1409342910:tgl,rkl,dg1,adl-s,adl-p + * Wa_1409178076:tgl,dg1,adl-p,adl-n + * Wa_1408979724:tgl,dg1,adl-p,adl-n + * Wa_14010443199:tgl,rkl,dg1,adl-p,adl-n + * Wa_14010698770:tgl,rkl,dg1,adl-s,adl-p,adl-n + * Wa_1409342910:tgl,rkl,dg1,adl-s,adl-p,adl-n + * Wa_22010465259:tgl,rkl,dg1,adl-s,adl-p,adl-n */ wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3, GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
Add Wa_22010465259 which points to an existing WA, but was missing from the comment list. While at it, update the other WAs and their applicable platforms as well. Signed-off-by: Ranu Maurya <ranu.maurya@intel.com> --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)