diff mbox series

[12/14] drm/i915: Make intel_bw_modeset_checks() internal to intel_bw_atomic_check()

Message ID 20250307180139.15744-13-ville.syrjala@linux.intel.com (mailing list archive)
State New
Headers show
Series drm/i915: sagv/bw cleanup | expand

Commit Message

Ville Syrjälä March 7, 2025, 6:01 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Now that all the sagv computation has been moved from the
skl+ watermark code into intel_bw_atomic_check() there is
no point in calling intel_bw_modeset_checks() before the
wm computation. Hide it within intel_bw_atomic_check().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_bw.c      | 10 ++++++++--
 drivers/gpu/drm/i915/display/intel_bw.h      |  3 +--
 drivers/gpu/drm/i915/display/intel_display.c |  8 +-------
 3 files changed, 10 insertions(+), 11 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index a39b75640b03..3407606be461 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -1379,7 +1379,7 @@  static int intel_bw_check_data_rate(struct intel_atomic_state *state, bool *chan
 	return 0;
 }
 
-int intel_bw_modeset_checks(struct intel_atomic_state *state)
+static int intel_bw_modeset_checks(struct intel_atomic_state *state)
 {
 	struct intel_display *display = to_intel_display(state);
 	const struct intel_bw_state *old_bw_state;
@@ -1448,7 +1448,7 @@  static int intel_bw_check_sagv_mask(struct intel_atomic_state *state)
 	return 0;
 }
 
-int intel_bw_atomic_check(struct intel_atomic_state *state)
+int intel_bw_atomic_check(struct intel_atomic_state *state, bool any_ms)
 {
 	bool changed = false;
 	struct drm_i915_private *i915 = to_i915(state->base.dev);
@@ -1459,6 +1459,12 @@  int intel_bw_atomic_check(struct intel_atomic_state *state)
 	if (DISPLAY_VER(i915) < 9)
 		return 0;
 
+	if (any_ms) {
+		ret = intel_bw_modeset_checks(state);
+		if (ret)
+			return ret;
+	}
+
 	ret = intel_bw_check_sagv_mask(state);
 	if (ret)
 		return ret;
diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm/i915/display/intel_bw.h
index 0efc9858faa1..d5e29599c158 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.h
+++ b/drivers/gpu/drm/i915/display/intel_bw.h
@@ -67,8 +67,7 @@  intel_atomic_get_bw_state(struct intel_atomic_state *state);
 
 void intel_bw_init_hw(struct drm_i915_private *dev_priv);
 int intel_bw_init(struct drm_i915_private *dev_priv);
-int intel_bw_modeset_checks(struct intel_atomic_state *state);
-int intel_bw_atomic_check(struct intel_atomic_state *state);
+int intel_bw_atomic_check(struct intel_atomic_state *state, bool any_ms);
 int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,
 				  u32 points_mask);
 int intel_bw_calc_min_cdclk(struct intel_atomic_state *state,
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 69e4c9be28f3..e75a2f167d7d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6423,17 +6423,11 @@  int intel_atomic_check(struct drm_device *dev,
 	if (ret)
 		goto fail;
 
-	if (any_ms) {
-		ret = intel_bw_modeset_checks(state);
-		if (ret)
-			goto fail;
-	}
-
 	ret = intel_compute_global_watermarks(state);
 	if (ret)
 		goto fail;
 
-	ret = intel_bw_atomic_check(state);
+	ret = intel_bw_atomic_check(state, any_ms);
 	if (ret)
 		goto fail;