| Message ID | 20250315120143.2344958-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] drm/i915/display: Fix build error without DRM_FBDEV_EMULATION | expand |
Am 15.03.25 um 13:01 schrieb Yue Haibing: > In file included from <command-line>: > ./drivers/gpu/drm/i915/display/intel_fbdev.h: In function ‘intel_fbdev_framebuffer’: > ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: error: ‘NULL’ undeclared (first use in this function) > 32 | return NULL; > | ^~~~ > ./drivers/gpu/drm/i915/display/intel_fbdev.h:1:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’? > +++ |+#include <stddef.h> > 1 | /* SPDX-License-Identifier: MIT */ > ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: note: each undeclared identifier is reported only once for each function it appears in > 32 | return NULL; > | ^~~~ > > Build fails if CONFIG_DRM_FBDEV_EMULATION is n, add missing header file. > > Fixes: 9fa154f40eb6 ("drm/{i915,xe}: Run DRM default client setup") > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/i915/display/intel_fbdev.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.h b/drivers/gpu/drm/i915/display/intel_fbdev.h > index ca2c8c438f02..89bad3a2b01a 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.h > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.h > @@ -6,6 +6,8 @@ > #ifndef __INTEL_FBDEV_H__ > #define __INTEL_FBDEV_H__ > > +#include <linux/types.h> > + > struct drm_fb_helper; > struct drm_fb_helper_surface_size; > struct drm_i915_private;
On Mon, 17 Mar 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote: > Am 15.03.25 um 13:01 schrieb Yue Haibing: >> In file included from <command-line>: >> ./drivers/gpu/drm/i915/display/intel_fbdev.h: In function ‘intel_fbdev_framebuffer’: >> ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: error: ‘NULL’ undeclared (first use in this function) >> 32 | return NULL; >> | ^~~~ >> ./drivers/gpu/drm/i915/display/intel_fbdev.h:1:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’? >> +++ |+#include <stddef.h> >> 1 | /* SPDX-License-Identifier: MIT */ >> ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: note: each undeclared identifier is reported only once for each function it appears in >> 32 | return NULL; >> | ^~~~ >> >> Build fails if CONFIG_DRM_FBDEV_EMULATION is n, add missing header file. >> >> Fixes: 9fa154f40eb6 ("drm/{i915,xe}: Run DRM default client setup") >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Merged to drm-intel-next, thanks for the patch and ack. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_fbdev.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.h b/drivers/gpu/drm/i915/display/intel_fbdev.h >> index ca2c8c438f02..89bad3a2b01a 100644 >> --- a/drivers/gpu/drm/i915/display/intel_fbdev.h >> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.h >> @@ -6,6 +6,8 @@ >> #ifndef __INTEL_FBDEV_H__ >> #define __INTEL_FBDEV_H__ >> >> +#include <linux/types.h> >> + >> struct drm_fb_helper; >> struct drm_fb_helper_surface_size; >> struct drm_i915_private;
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.h b/drivers/gpu/drm/i915/display/intel_fbdev.h index ca2c8c438f02..89bad3a2b01a 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.h +++ b/drivers/gpu/drm/i915/display/intel_fbdev.h @@ -6,6 +6,8 @@ #ifndef __INTEL_FBDEV_H__ #define __INTEL_FBDEV_H__ +#include <linux/types.h> + struct drm_fb_helper; struct drm_fb_helper_surface_size; struct drm_i915_private;
In file included from <command-line>: ./drivers/gpu/drm/i915/display/intel_fbdev.h: In function ‘intel_fbdev_framebuffer’: ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: error: ‘NULL’ undeclared (first use in this function) 32 | return NULL; | ^~~~ ./drivers/gpu/drm/i915/display/intel_fbdev.h:1:1: note: ‘NULL’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’? +++ |+#include <stddef.h> 1 | /* SPDX-License-Identifier: MIT */ ./drivers/gpu/drm/i915/display/intel_fbdev.h:32:16: note: each undeclared identifier is reported only once for each function it appears in 32 | return NULL; | ^~~~ Build fails if CONFIG_DRM_FBDEV_EMULATION is n, add missing header file. Fixes: 9fa154f40eb6 ("drm/{i915,xe}: Run DRM default client setup") Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/gpu/drm/i915/display/intel_fbdev.h | 2 ++ 1 file changed, 2 insertions(+)