| Message ID | 20250319191508.2751216-9-animesh.manna@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | LOBF enablement fix | expand |
On Thu, 2025-03-20 at 00:45 +0530, Animesh Manna wrote: > Lobf is enabled part of ALPM configuration and if has_lobf > is set to true respective bit for LOBF will be set. Add debug > print while setting the bitfield of LOBF. Maybe disable is valuable information as well? You could add that into patch 2: Reviewed-by: Jouni Högander <jouni.hogander@intel.com> > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > b/drivers/gpu/drm/i915/display/intel_alpm.c > index b44aeef390a6..25c41cd6ad24 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -362,8 +362,10 @@ static void lnl_alpm_configure(struct intel_dp > *intel_dp, > ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp- > >alpm_parameters.fast_wake_lines); > } > > - if (crtc_state->has_lobf) > + if (crtc_state->has_lobf) { > alpm_ctl |= ALPM_CTL_LOBF_ENABLE; > + drm_dbg_kms(display->drm, "Link off between frames > (LOBF) enabled\n"); > + } > > alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp- > >alpm_parameters.check_entry_lines); >
> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, March 24, 2025 1:29 PM > To: intel-xe@lists.freedesktop.org; Manna, Animesh > <animesh.manna@intel.com>; intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v6 8/8] drm/i915/lobf: Add debug print for LOBF > > On Thu, 2025-03-20 at 00:45 +0530, Animesh Manna wrote: > > Lobf is enabled part of ALPM configuration and if has_lobf is set to > > true respective bit for LOBF will be set. Add debug print while > > setting the bitfield of LOBF. > > Maybe disable is valuable information as well? You could add that into patch > 2: > > Reviewed-by: Jouni Högander <jouni.hogander@intel.com> Sure. Regards, Animesh > > > > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > index b44aeef390a6..25c41cd6ad24 100644 > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > @@ -362,8 +362,10 @@ static void lnl_alpm_configure(struct intel_dp > > *intel_dp, > > ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp- > > >alpm_parameters.fast_wake_lines); > > } > > > > - if (crtc_state->has_lobf) > > + if (crtc_state->has_lobf) { > > alpm_ctl |= ALPM_CTL_LOBF_ENABLE; > > + drm_dbg_kms(display->drm, "Link off between frames > > (LOBF) enabled\n"); > > + } > > > > alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp- > > >alpm_parameters.check_entry_lines); > >
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index b44aeef390a6..25c41cd6ad24 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -362,8 +362,10 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp, ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp->alpm_parameters.fast_wake_lines); } - if (crtc_state->has_lobf) + if (crtc_state->has_lobf) { alpm_ctl |= ALPM_CTL_LOBF_ENABLE; + drm_dbg_kms(display->drm, "Link off between frames (LOBF) enabled\n"); + } alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines);
Lobf is enabled part of ALPM configuration and if has_lobf is set to true respective bit for LOBF will be set. Add debug print while setting the bitfield of LOBF. Signed-off-by: Animesh Manna <animesh.manna@intel.com> --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)