| Message ID | 20250324083755.12489-4-kwizart@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] Revert "drm/i915/gvt: Fix out-of-bounds buffer write into opregion->signature[]" | expand |
On Mon, 24 Mar 2025, Nicolas Chauvet <kwizart@gmail.com> wrote: > Change the OPREGION_SIGNATURE name so it fit into the > opregion_header->signature size. > > Cc: stable@vger.kernel.org > Fixes: 93615d59912 ("Revert drm/i915/gvt: Fix out-of-bounds buffer write into opregion->signature[]") > Signed-off-by: Nicolas Chauvet <kwizart@gmail.com> Nope, can't do that. The signature is used for checking data in memory. Which should be obvious if you'd looked at how it's being used or if this was tested. BR, Jani. > --- > drivers/gpu/drm/i915/gvt/opregion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c > index 0f11cd6ba383..0bd02dfaceb1 100644 > --- a/drivers/gpu/drm/i915/gvt/opregion.c > +++ b/drivers/gpu/drm/i915/gvt/opregion.c > @@ -32,7 +32,7 @@ > #define _INTEL_BIOS_PRIVATE > #include "display/intel_vbt_defs.h" > > -#define OPREGION_SIGNATURE "IntelGraphicsMem" > +#define OPREGION_SIGNATURE "IntelGFXMem" > #define MBOX_VBT (1<<3) > > /* device handle */
diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c index 0f11cd6ba383..0bd02dfaceb1 100644 --- a/drivers/gpu/drm/i915/gvt/opregion.c +++ b/drivers/gpu/drm/i915/gvt/opregion.c @@ -32,7 +32,7 @@ #define _INTEL_BIOS_PRIVATE #include "display/intel_vbt_defs.h" -#define OPREGION_SIGNATURE "IntelGraphicsMem" +#define OPREGION_SIGNATURE "IntelGFXMem" #define MBOX_VBT (1<<3) /* device handle */
Change the OPREGION_SIGNATURE name so it fit into the opregion_header->signature size. Cc: stable@vger.kernel.org Fixes: 93615d59912 ("Revert drm/i915/gvt: Fix out-of-bounds buffer write into opregion->signature[]") Signed-off-by: Nicolas Chauvet <kwizart@gmail.com> --- drivers/gpu/drm/i915/gvt/opregion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)