diff mbox series

[4/4] drm/i915/pci: Remove force_probe requirement for DG1

Message ID 20250401163752.6412-5-ville.syrjala@linux.intel.com (mailing list archive)
State New
Headers show
Series drm/i915: DG1 fixes | expand

Commit Message

Ville Syrjala April 1, 2025, 4:37 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Dunno why we still have .require_force_probe=1 on DG1 after
all this time. I'm not aware of any real problems with DG1,
so get rid of the force_probe requirement.

Generally the difficulty with DG1 is that it requires a
4GiB BAR for the local memory, and that's not something
that works on every system.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andi Shyti April 1, 2025, 5:34 p.m. UTC | #1 
Hi Ville,

On Tue, Apr 01, 2025 at 07:37:52PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Dunno why we still have .require_force_probe=1 on DG1 after
> all this time. I'm not aware of any real problems with DG1,
> so get rid of the force_probe requirement.

Excellent!

> Generally the difficulty with DG1 is that it requires a
> 4GiB BAR for the local memory, and that's not something
> that works on every system.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 21006c7f615c..b2e311f4791a 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -663,7 +663,6 @@  static const struct intel_device_info dg1_info = {
 	DGFX_FEATURES,
 	.__runtime.graphics.ip.rel = 10,
 	PLATFORM(INTEL_DG1),
-	.require_force_probe = 1,
 	.platform_engine_mask =
 		BIT(RCS0) | BIT(BCS0) | BIT(VECS0) |
 		BIT(VCS0) | BIT(VCS2),