| Message ID | 241c5886cf2e95c694a693bb1b1953f6ae15390e.1744295009.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/debugfs: caps cleanups | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Thursday, April 10, 2025 7:54 PM > To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com> > Subject: [PATCH 1/2] drm/i915/debugfs: remove i915_display_capabilities > > Turns out we've added two similar debugfs files. Consolidate on > intel_display_caps as it has more info and a driver independent name. > > IGT has already switched over to intel_display_caps in IGT commit > cf837fc17d6c ("lib/dsc: use intel_display_caps instead of > i915_display_capabilities"). > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> LGTM, Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index 8f1f95637e09..d43ae6729f21 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -610,17 +610,6 @@ static int i915_display_info(struct seq_file *m, void > *unused) > return 0; > } > > -static int i915_display_capabilities(struct seq_file *m, void *unused) -{ > - struct intel_display *display = node_to_intel_display(m->private); > - struct drm_printer p = drm_seq_file_printer(m); > - > - intel_display_device_info_print(DISPLAY_INFO(display), > - DISPLAY_RUNTIME_INFO(display), > &p); > - > - return 0; > -} > - > static int i915_shared_dplls_info(struct seq_file *m, void *unused) { > struct intel_display *display = node_to_intel_display(m->private); > @@ -817,7 +806,6 @@ static const struct drm_info_list > intel_display_debugfs_list[] = { > {"i915_gem_framebuffer", i915_gem_framebuffer_info, 0}, > {"i915_power_domain_info", i915_power_domain_info, 0}, > {"i915_display_info", i915_display_info, 0}, > - {"i915_display_capabilities", i915_display_capabilities, 0}, > {"i915_shared_dplls_info", i915_shared_dplls_info, 0}, > {"i915_dp_mst_info", i915_dp_mst_info, 0}, > {"i915_ddb_info", i915_ddb_info, 0}, > -- > 2.39.5
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 8f1f95637e09..d43ae6729f21 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -610,17 +610,6 @@ static int i915_display_info(struct seq_file *m, void *unused) return 0; } -static int i915_display_capabilities(struct seq_file *m, void *unused) -{ - struct intel_display *display = node_to_intel_display(m->private); - struct drm_printer p = drm_seq_file_printer(m); - - intel_display_device_info_print(DISPLAY_INFO(display), - DISPLAY_RUNTIME_INFO(display), &p); - - return 0; -} - static int i915_shared_dplls_info(struct seq_file *m, void *unused) { struct intel_display *display = node_to_intel_display(m->private); @@ -817,7 +806,6 @@ static const struct drm_info_list intel_display_debugfs_list[] = { {"i915_gem_framebuffer", i915_gem_framebuffer_info, 0}, {"i915_power_domain_info", i915_power_domain_info, 0}, {"i915_display_info", i915_display_info, 0}, - {"i915_display_capabilities", i915_display_capabilities, 0}, {"i915_shared_dplls_info", i915_shared_dplls_info, 0}, {"i915_dp_mst_info", i915_dp_mst_info, 0}, {"i915_ddb_info", i915_ddb_info, 0},
Turns out we've added two similar debugfs files. Consolidate on intel_display_caps as it has more info and a driver independent name. IGT has already switched over to intel_display_caps in IGT commit cf837fc17d6c ("lib/dsc: use intel_display_caps instead of i915_display_capabilities"). Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ------------ 1 file changed, 12 deletions(-)