diff mbox series

[i-g-t] gitlab-ci: add tests for MIPS

Message ID 40326e43def140d19e0d57604e41aa10d1466f7a.1561642240.git.guillaume.tucker@collabora.com (mailing list archive)
State New, archived
Headers show
Series [i-g-t] gitlab-ci: add tests for MIPS | expand

Commit Message

Guillaume Tucker June 27, 2019, 1:30 p.m. UTC
Use the libatomic1:mips package only in the Debian Stretch Docker
image for MIPS and add Gitlab CI step to run tests on MIPS.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---
 .gitlab-ci.yml         | 14 ++++++++++++++
 Dockerfile.debian-mips |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)

Comments

Ser, Simon June 27, 2019, 2:51 p.m. UTC | #1
On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote:
> Use the libatomic1:mips package only in the Debian Stretch Docker
> image for MIPS and add Gitlab CI step to run tests on MIPS.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>

With this tag added:

Fixes: 439a9f5d615f ("gitlab-ci: add build for MIPS")

This patch is:

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
>  .gitlab-ci.yml         | 14 ++++++++++++++
>  Dockerfile.debian-mips |  2 +-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 37184b98f5da..665fbb79c523 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -173,6 +173,20 @@ test:ninja-test-armhf:
>        - build
>      when: on_failure
>  
> +test:ninja-test-mips:
> +  image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-mips:latest
> +  dependencies:
> +    - build:tests-debian-meson-mips
> +  stage: test
> +  script:
> +    - export PKG_CONFIG_PATH=/usr/lib/mips-linux-gnu/pkgconfig/
> +    - env > build/envdump.txt
> +    - ninja -C build test
> +  artifacts:
> +    paths:
> +      - build
> +    when: on_failure
> +
>  test:test-list-diff:
>    dependencies:
>      - build:tests-debian-autotools
> diff --git a/Dockerfile.debian-mips b/Dockerfile.debian-mips
> index ebe08db644ea..ee29f5f4ccda 100644
> --- a/Dockerfile.debian-mips
> +++ b/Dockerfile.debian-mips
> @@ -5,7 +5,6 @@ RUN apt-get install -y \
>  			flex \
>  			bison \
>  			pkg-config \
> -			libatomic1 \
>  			x11proto-dri2-dev \
>  			python-docutils \
>  			valgrind \
> @@ -15,6 +14,7 @@ RUN dpkg --add-architecture mips
>  RUN apt-get update
>  RUN apt-get install -y \
>  			gcc-mips-linux-gnu \
> +			libatomic1:mips \
>  			libpciaccess-dev:mips \
>  			libkmod-dev:mips \
>  			libprocps-dev:mips \
Ser, Simon June 28, 2019, 6:46 a.m. UTC | #2
On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote:
> Use the libatomic1:mips package only in the Debian Stretch Docker
> image for MIPS and add Gitlab CI step to run tests on MIPS.
> 
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>

And pushed:

To gitlab.freedesktop.org:drm/igt-gpu-tools.git
   3c4edeba35ac..5f6cf7070b24  master -> master

Thanks!

> ---
>  .gitlab-ci.yml         | 14 ++++++++++++++
>  Dockerfile.debian-mips |  2 +-
>  2 files changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 37184b98f5da..665fbb79c523 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -173,6 +173,20 @@ test:ninja-test-armhf:
>        - build
>      when: on_failure
>  
> +test:ninja-test-mips:
> +  image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-mips:latest
> +  dependencies:
> +    - build:tests-debian-meson-mips
> +  stage: test
> +  script:
> +    - export PKG_CONFIG_PATH=/usr/lib/mips-linux-gnu/pkgconfig/
> +    - env > build/envdump.txt
> +    - ninja -C build test
> +  artifacts:
> +    paths:
> +      - build
> +    when: on_failure
> +
>  test:test-list-diff:
>    dependencies:
>      - build:tests-debian-autotools
> diff --git a/Dockerfile.debian-mips b/Dockerfile.debian-mips
> index ebe08db644ea..ee29f5f4ccda 100644
> --- a/Dockerfile.debian-mips
> +++ b/Dockerfile.debian-mips
> @@ -5,7 +5,6 @@ RUN apt-get install -y \
>  			flex \
>  			bison \
>  			pkg-config \
> -			libatomic1 \
>  			x11proto-dri2-dev \
>  			python-docutils \
>  			valgrind \
> @@ -15,6 +14,7 @@ RUN dpkg --add-architecture mips
>  RUN apt-get update
>  RUN apt-get install -y \
>  			gcc-mips-linux-gnu \
> +			libatomic1:mips \
>  			libpciaccess-dev:mips \
>  			libkmod-dev:mips \
>  			libprocps-dev:mips \
Arkadiusz Hiler June 28, 2019, 6:47 a.m. UTC | #3
On Thu, Jun 27, 2019 at 05:51:32PM +0300, Ser, Simon wrote:
> On Thu, 2019-06-27 at 14:30 +0100, Guillaume Tucker wrote:
> > Use the libatomic1:mips package only in the Debian Stretch Docker
> > image for MIPS and add Gitlab CI step to run tests on MIPS.
> > 
> > Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> 
> With this tag added:
> 
> Fixes: 439a9f5d615f ("gitlab-ci: add build for MIPS")
> 
> This patch is:
> 
> Reviewed-by: Simon Ser <simon.ser@intel.com>

Hey,

https://patchwork.freedesktop.org/series/62859/ and check GitLab.Pipeline

We will be running gitlab pipeline for everything pre-merge and if it
fails we will send out a email (currently we are testing this and no
emails are sent).

You can check the pieline status from patchwork at all times, even for
sucessful ones :-)
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 37184b98f5da..665fbb79c523 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -173,6 +173,20 @@  test:ninja-test-armhf:
       - build
     when: on_failure
 
+test:ninja-test-mips:
+  image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-mips:latest
+  dependencies:
+    - build:tests-debian-meson-mips
+  stage: test
+  script:
+    - export PKG_CONFIG_PATH=/usr/lib/mips-linux-gnu/pkgconfig/
+    - env > build/envdump.txt
+    - ninja -C build test
+  artifacts:
+    paths:
+      - build
+    when: on_failure
+
 test:test-list-diff:
   dependencies:
     - build:tests-debian-autotools
diff --git a/Dockerfile.debian-mips b/Dockerfile.debian-mips
index ebe08db644ea..ee29f5f4ccda 100644
--- a/Dockerfile.debian-mips
+++ b/Dockerfile.debian-mips
@@ -5,7 +5,6 @@  RUN apt-get install -y \
 			flex \
 			bison \
 			pkg-config \
-			libatomic1 \
 			x11proto-dri2-dev \
 			python-docutils \
 			valgrind \
@@ -15,6 +14,7 @@  RUN dpkg --add-architecture mips
 RUN apt-get update
 RUN apt-get install -y \
 			gcc-mips-linux-gnu \
+			libatomic1:mips \
 			libpciaccess-dev:mips \
 			libkmod-dev:mips \
 			libprocps-dev:mips \