From patchwork Wed Jul 15 13:20:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maarten Lankhorst X-Patchwork-Id: 6798911 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 41604C05AC for ; Wed, 15 Jul 2015 13:20:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4B7BC205BA for ; Wed, 15 Jul 2015 13:20:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 6EECF20529 for ; Wed, 15 Jul 2015 13:20:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 002EF6E387; Wed, 15 Jul 2015 06:20:47 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 934276E387 for ; Wed, 15 Jul 2015 06:20:45 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 15 Jul 2015 06:20:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,480,1432623600"; d="scan'208";a="764930490" Received: from cfinn-mobl.ger.corp.intel.com (HELO patser.lan) ([10.252.21.57]) by orsmga002.jf.intel.com with ESMTP; 15 Jul 2015 06:20:35 -0700 Message-ID: <55A65E22.1090608@linux.intel.com> Date: Wed, 15 Jul 2015 15:20:34 +0200 From: Maarten Lankhorst User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Daniel Vetter , Intel Graphics Development References: <1436962552-17477-1-git-send-email-daniel.vetter@ffwll.ch> <1436962552-17477-2-git-send-email-daniel.vetter@ffwll.ch> In-Reply-To: <1436962552-17477-2-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter Subject: [Intel-gfx] [PATCH 4/3] drm/i915: Clarify logic for initial modeset X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hey, Op 15-07-15 om 14:15 schreef Daniel Vetter: > Currently we both set mode->private_flags to some value and also use > the pipe_config quirk. But since the pipe_config quirk isn't tied to > the lifetime of the mode object we need to check both. > > Simplify this by only using mode.private_flags and stop using the > INHERITED_MODE quirk. Also for clarity add an explicit #define for > that driver priavete mode flag. > > By using crtc_state->mode_changed we can also remove the recalc local > variable. Those 3 changes look good to me. Reviewed-by: Maarten Lankhorst Any objections against this followup patch? Or should I wait until I made intel_update_pipe_size atomic? diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index 7eff33ff84f6..914679ceb200 100644 --- a/drivers/gpu/drm/i915/intel_fbdev.c +++ b/drivers/gpu/drm/i915/intel_fbdev.c @@ -578,9 +578,6 @@ static bool intel_fbdev_init_bios(struct drm_device *dev, struct intel_crtc *intel_crtc; unsigned int max_size = 0; - if (!i915.fastboot) - return false; - /* Find the largest fb */ for_each_crtc(dev, crtc) { struct drm_i915_gem_object *obj =