| Message ID | 5c8f7d1a1654436d38919b7419a209c129db8ad0.1545920737.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: modparam rework prep work | expand |
On 27/12/2018 14:33, Jani Nikula wrote: > i915.enable_hangcheck has been an outlier since its introduction in > commit 3e0dc6b01f53 ("drm/i915: hangcheck disable parameter") with 0644 > permissions, while all the rest are either 0400 or 0600. Follow suit > with 0600. > > IGT never reads the value, so there should be no impact. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 81c73bfc7991..9f0539bdaa39 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -77,7 +77,7 @@ i915_param_named(error_capture, bool, 0600, > "triaging and debugging hangs."); > #endif > > -i915_param_named_unsafe(enable_hangcheck, bool, 0644, > +i915_param_named_unsafe(enable_hangcheck, bool, 0600, > "Periodically check GPU activity for detecting hangs. " > "WARNING: Disabling this can cause system wide hangs. " > "(default: true)"); > Having dug out the introducing commit, there doesn't seem to be a special reason for it to be 0644 indeed: commit 3e0dc6b01f5301d63046f6deddde2c7f5c57d67a Author: Ben Widawsky <ben@bwidawsk.net> Date: Wed Jun 29 10:26:42 2011 -0700 drm/i915: hangcheck disable parameter Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
On Mon, 31 Dec 2018, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > On 27/12/2018 14:33, Jani Nikula wrote: >> i915.enable_hangcheck has been an outlier since its introduction in >> commit 3e0dc6b01f53 ("drm/i915: hangcheck disable parameter") with 0644 >> permissions, while all the rest are either 0400 or 0600. Follow suit >> with 0600. >> >> IGT never reads the value, so there should be no impact. >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/i915_params.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c >> index 81c73bfc7991..9f0539bdaa39 100644 >> --- a/drivers/gpu/drm/i915/i915_params.c >> +++ b/drivers/gpu/drm/i915/i915_params.c >> @@ -77,7 +77,7 @@ i915_param_named(error_capture, bool, 0600, >> "triaging and debugging hangs."); >> #endif >> >> -i915_param_named_unsafe(enable_hangcheck, bool, 0644, >> +i915_param_named_unsafe(enable_hangcheck, bool, 0600, >> "Periodically check GPU activity for detecting hangs. " >> "WARNING: Disabling this can cause system wide hangs. " >> "(default: true)"); >> > > Having dug out the introducing commit, there doesn't seem to be a > special reason for it to be 0644 indeed: > > commit 3e0dc6b01f5301d63046f6deddde2c7f5c57d67a > Author: Ben Widawsky <ben@bwidawsk.net> > Date: Wed Jun 29 10:26:42 2011 -0700 > > drm/i915: hangcheck disable parameter > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the reviews, pushed patches 1-4 in the series. BR, Jani. > > Regards, > > Tvrtko
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 81c73bfc7991..9f0539bdaa39 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -77,7 +77,7 @@ i915_param_named(error_capture, bool, 0600, "triaging and debugging hangs."); #endif -i915_param_named_unsafe(enable_hangcheck, bool, 0644, +i915_param_named_unsafe(enable_hangcheck, bool, 0600, "Periodically check GPU activity for detecting hangs. " "WARNING: Disabling this can cause system wide hangs. " "(default: true)");
i915.enable_hangcheck has been an outlier since its introduction in commit 3e0dc6b01f53 ("drm/i915: hangcheck disable parameter") with 0644 permissions, while all the rest are either 0400 or 0600. Follow suit with 0600. IGT never reads the value, so there should be no impact. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)