diff mbox series

[3/5] drm/i915/ipc: register debugfs only if IPC available

Message ID 65c7d79adbfbd8a5b69217b0f9437d8798c17218.1662400767.git.jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: ipc and display sub-struct refactoring | expand

Commit Message

Jani Nikula Sept. 5, 2022, 6:01 p.m. UTC 
It looks like trying to enable IPC via debugfs on platforms that don't
have IPC resulted in dmesg info message about IPC being enabled, which
is clearly not possible and would not happen.

Seems sensible to register IPC debugfs only on platforms that have IPC.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ipc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ipc.c b/drivers/gpu/drm/i915/display/intel_ipc.c
index 389d7d8012d9..1285d88b5d25 100644
--- a/drivers/gpu/drm/i915/display/intel_ipc.c
+++ b/drivers/gpu/drm/i915/display/intel_ipc.c
@@ -68,9 +68,6 @@  static int intel_ipc_status_open(struct inode *inode, struct file *file)
 {
 	struct drm_i915_private *i915 = inode->i_private;
 
-	if (!HAS_IPC(i915))
-		return -ENODEV;
-
 	return single_open(file, intel_ipc_status_show, i915);
 }
 
@@ -111,6 +108,9 @@  void intel_ipc_debugfs_register(struct drm_i915_private *i915)
 {
 	struct drm_minor *minor = i915->drm.primary;
 
+	if (!HAS_IPC(i915))
+		return;
+
 	debugfs_create_file("i915_ipc_status", 0644, minor->debugfs_root,
 			    i915, &intel_ipc_status_fops);
 }