| Message ID | 75829068c82e7517d9b85119936a2c645682f591.1396264683.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 31, 2014 at 02:27:22PM +0300, Jani Nikula wrote: > There are no longer users of drm_i915_private_t. Drop the typedef. Good > riddance. One last test, we expect i915.ko to be the same before and after. Good riddance, Acked-by: Chris Wilson <chris@chris-wislon.co.uk> -Chris
On Mon, 31 Mar 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote: > On Mon, Mar 31, 2014 at 02:27:22PM +0300, Jani Nikula wrote: >> There are no longer users of drm_i915_private_t. Drop the typedef. Good >> riddance. > > One last test, we expect i915.ko to be the same before and after. Any tips for this one? I tried: $ strip --strip-all --remove-section=.note.gnu.build-id i915.ko before diffing but it's not sufficient. BR, Jani. > Good riddance, > Acked-by: Chris Wilson <chris@chris-wislon.co.uk> ^^ ?
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 2f1d20ac7333..ff02225d5edd 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1253,7 +1253,7 @@ struct intel_pipe_crc { wait_queue_head_t wq; }; -typedef struct drm_i915_private { +struct drm_i915_private { struct drm_device *dev; struct kmem_cache *slab; @@ -1459,7 +1459,7 @@ typedef struct drm_i915_private { struct i915_dri1_state dri1; /* Old ums support infrastructure, same warning applies. */ struct i915_ums_state ums; -} drm_i915_private_t; +}; static inline struct drm_i915_private *to_i915(const struct drm_device *dev) {
There are no longer users of drm_i915_private_t. Drop the typedef. Good riddance. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)