diff mbox

drm/i915: Dump pipe config when intel_modeset_pipe_config fails.

Message ID 843f4327-1574-cf8e-0776-adbb0d58c2c0@mblankhorst.nl (mailing list archive)
State New, archived
Headers show

Commit Message

Maarten Lankhorst May 3, 2016, 8:30 a.m. UTC 
This makes it easier to debug issues like https://bugs.freedesktop.org/show_bug.cgi?id=93477

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Chris Wilson <|chris@chris-wilson.co.uk>|
---

Comments

Daniel Vetter May 9, 2016, 7:14 a.m. UTC | #1 
On Tue, May 03, 2016 at 10:30:38AM +0200, Maarten Lankhorst wrote:
> This makes it easier to debug issues like https://bugs.freedesktop.org/show_bug.cgi?id=93477
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Chris Wilson <|chris@chris-wilson.co.uk>|
> ---
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cd415143a493..339c79e6524f 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13449,8 +13449,11 @@ static int intel_atomic_check(struct drm_device *dev,
>  			return ret;
>  
>  		ret = intel_modeset_pipe_config(crtc, pipe_config);
> -		if (ret)
> +		if (ret) {
> +			intel_dump_pipe_config(to_intel_crtc(crtc),
> +					       pipe_config, "[failed]");
>  			return ret;
> +		}

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>  
>  		if (i915.fastboot &&
>  		    intel_pipe_config_compare(dev,
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index cd415143a493..339c79e6524f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13449,8 +13449,11 @@  static int intel_atomic_check(struct drm_device *dev,
 			return ret;
 
 		ret = intel_modeset_pipe_config(crtc, pipe_config);
-		if (ret)
+		if (ret) {
+			intel_dump_pipe_config(to_intel_crtc(crtc),
+					       pipe_config, "[failed]");
 			return ret;
+		}
 
 		if (i915.fastboot &&
 		    intel_pipe_config_compare(dev,