From patchwork Tue May 27 18:17:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jani Nikula X-Patchwork-Id: 4250981 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1DC22BF90B for ; Tue, 27 May 2014 18:21:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 40E29201FE for ; Tue, 27 May 2014 18:21:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 554C4201BB for ; Tue, 27 May 2014 18:21:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D930B6E2DC; Tue, 27 May 2014 11:21:48 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D13B6E2DC for ; Tue, 27 May 2014 11:21:46 -0700 (PDT) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 27 May 2014 11:17:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,921,1392192000"; d="scan'208";a="437485759" Received: from kcthilak-mobl.gar.corp.intel.com (HELO localhost) ([10.252.120.32]) by azsmga001.ch.intel.com with ESMTP; 27 May 2014 11:17:42 -0700 From: Jani Nikula To: Daniel Vetter In-Reply-To: <20140527171923.GI14841@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1401207852-2115-1-git-send-email-jani.nikula@intel.com> <20140527171923.GI14841@phenom.ffwll.local> User-Agent: Notmuch/0.18+16~gec02089 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 27 May 2014 21:17:41 +0300 Message-ID: <87vbsrm6gq.fsf@intel.com> MIME-Version: 1.0 Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: tell the user if both KMS and UMS are disabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 27 May 2014, Daniel Vetter wrote: > On Tue, May 27, 2014 at 07:24:12PM +0300, Jani Nikula wrote: >> If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and >> UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might >> not be aware his setup is not supported. Inform the users (and, by >> extension, the poor i915 developers having to read their dmesgs in bug >> reports) why their graphics experience might be lacking. >> >> A similar message was added on the UMS path in >> commit e147accbd19f55489dabdcc4dc3551cc3e3f2553 >> Author: Jani Nikula >> Date: Thu Oct 10 15:25:37 2013 +0300 >> >> drm/i915: tell the user KMS is required for gen6+ >> >> but it won't be reached if CONFIG_DRM_I915_UMS=n since >> commit b30324adaf8d2e5950a602bde63030d15a61826f >> Author: Daniel Vetter >> Date: Wed Nov 13 22:11:25 2013 +0100 >> >> drm/i915: Deprecated UMS support >> >> Signed-off-by: Jani Nikula > > Hm, the idea is that this fails _very_ silently so that people only send > us regression reports if they actually notice something. Since if there > are still people out there which needs UMS, we can't yet rip it out. My gut feeling from bug reports is that, since CONFIG_DRM_I915_UMS now defaults to n, we mostly end up here because users have issues with KMS and try nomodeset as a workaround. Is this silent enough, same commit message: BR, Jani. > -Daniel > >> --- >> drivers/gpu/drm/i915/i915_drv.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c >> index 8949fd26b0ea..f0f690776d45 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -1584,6 +1584,8 @@ static int __init i915_init(void) >> if (!(driver.driver_features & DRIVER_MODESET)) { >> driver.get_vblank_timestamp = NULL; >> #ifndef CONFIG_DRM_I915_UMS >> + DRM_INFO("Kernel modesetting (KMS) and userspace modesetting (UMS) disabled\n"); >> + DRM_INFO("See CONFIG_DRM_I915_UMS, CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n"); >> /* Silently fail loading to not upset userspace. */ >> return 0; >> #endif >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 8949fd26b0ea..ca46e6cf4b99 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1585,6 +1585,7 @@ static int __init i915_init(void) driver.get_vblank_timestamp = NULL; #ifndef CONFIG_DRM_I915_UMS /* Silently fail loading to not upset userspace. */ + DRM_DEBUG_DRIVER("KMS and UMS disabled.\n"); return 0; #endif }