diff mbox

[v2,5/6] drm/i915/dsi: use the BIT macro for clarity

Message ID 9115c0a80ad57075700e006db965dd31cc4358fc.1458313400.git.jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula March 18, 2016, 3:05 p.m. UTC 
No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_dsi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Ville Syrjälä March 18, 2016, 3:38 p.m. UTC | #1 
On Fri, Mar 18, 2016 at 05:05:43PM +0200, Jani Nikula wrote:
> No functional changes.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 1981212ffc8d..dd6f7bc4f444 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -412,7 +412,7 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder)
>  		temp &= ~LANE_CONFIGURATION_MASK;
>  		temp &= ~DUAL_LINK_MODE_MASK;
>  
> -		if (intel_dsi->ports == ((1 << PORT_A) | (1 << PORT_C))) {
> +		if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
>  			temp |= (intel_dsi->dual_link - 1)
>  						<< DUAL_LINK_MODE_SHIFT;
>  			temp |= intel_crtc->pipe ?
> @@ -1200,14 +1200,14 @@ void intel_dsi_init(struct drm_device *dev)
>  
>  	/* Pipe A maps to MIPI DSI port A, pipe B maps to MIPI DSI port C */
>  	if (port == PORT_A)
> -		intel_encoder->crtc_mask = 1 << PIPE_A;
> +		intel_encoder->crtc_mask = BIT(PIPE_A);
>  	else
> -		intel_encoder->crtc_mask = 1 << PIPE_B;
> +		intel_encoder->crtc_mask = BIT(PIPE_B);
>  
>  	if (dev_priv->vbt.dsi.config->dual_link)
> -		intel_dsi->ports = (1 << PORT_A) | (1 << PORT_C);
> +		intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C);
>  	else
> -		intel_dsi->ports = 1 << port;
> +		intel_dsi->ports = BIT(port);
>  
>  	/* Create a DSI host (and a device) for each port. */
>  	for_each_dsi_port(port, intel_dsi->ports) {
> -- 
> 2.1.4
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 1981212ffc8d..dd6f7bc4f444 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -412,7 +412,7 @@  static void intel_dsi_port_enable(struct intel_encoder *encoder)
 		temp &= ~LANE_CONFIGURATION_MASK;
 		temp &= ~DUAL_LINK_MODE_MASK;
 
-		if (intel_dsi->ports == ((1 << PORT_A) | (1 << PORT_C))) {
+		if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
 			temp |= (intel_dsi->dual_link - 1)
 						<< DUAL_LINK_MODE_SHIFT;
 			temp |= intel_crtc->pipe ?
@@ -1200,14 +1200,14 @@  void intel_dsi_init(struct drm_device *dev)
 
 	/* Pipe A maps to MIPI DSI port A, pipe B maps to MIPI DSI port C */
 	if (port == PORT_A)
-		intel_encoder->crtc_mask = 1 << PIPE_A;
+		intel_encoder->crtc_mask = BIT(PIPE_A);
 	else
-		intel_encoder->crtc_mask = 1 << PIPE_B;
+		intel_encoder->crtc_mask = BIT(PIPE_B);
 
 	if (dev_priv->vbt.dsi.config->dual_link)
-		intel_dsi->ports = (1 << PORT_A) | (1 << PORT_C);
+		intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C);
 	else
-		intel_dsi->ports = 1 << port;
+		intel_dsi->ports = BIT(port);
 
 	/* Create a DSI host (and a device) for each port. */
 	for_each_dsi_port(port, intel_dsi->ports) {