From patchwork Thu Jul 25 09:58:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 2833303 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3922A9F4D4 for ; Thu, 25 Jul 2013 09:59:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 577E020209 for ; Thu, 25 Jul 2013 09:59:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 068D320202 for ; Thu, 25 Jul 2013 09:59:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D86F5E6FD4 for ; Thu, 25 Jul 2013 02:59:23 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 5603CE6FC4 for ; Thu, 25 Jul 2013 02:58:27 -0700 (PDT) Received: by mail-ob0-f173.google.com with SMTP id er7so1037936obc.18 for ; Thu, 25 Jul 2013 02:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=JNT8Dj4njFQPXRB8wSG3bn0VCEFgNAyF17GT7ZRDZVU=; b=GyaVq2YjDMWHrPaIlxW3Lk1wEOuieiUMsXdSKUDxTHF/9cyWMyFVtGVV7HYaj9gK8j nj6tXxFnvagdpV1TH+JiWcNdrl24TAFygcX3+XCp1ol0rYxyPu0nUP+2fHHCB2dUOiVr ZyERw8PpgGaf1V/gVg0N6zOoIMpPPzX2S4tBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=JNT8Dj4njFQPXRB8wSG3bn0VCEFgNAyF17GT7ZRDZVU=; b=TBCndOb7L67Gv3FeAV0NJv1/HIiFoVk+QuIvDBcGrEZJnceNqxUIT7BWT4L2O47zRL aDo6Mo+7ec9JsT2qsv83tbxr11nd+S9OUfSSR+CCtBOrblJvpXjf0djT5wB4idzxS5gv blkpYeBRtJ6CRC0RJXpBPP3uTUW8ZETyxIZzFVxOTuHW/VPLVw2xNEUhPjkFCp+PoEmC PmwRvtsA5j2wvCy+1ojql6wNfLQSDKOdNFYmuQM6HyjtHAS5Imb0pocpPy72fLSpMeLW fXASSQSe/NS+nmVrS1s3GwjD4lYyCVD9VMj0ut9JcRcMgIIjcFh57uBxKVJ9Y3O1fj8g w3Pg== MIME-Version: 1.0 X-Received: by 10.50.126.74 with SMTP id mw10mr234549igb.20.1374746306234; Thu, 25 Jul 2013 02:58:26 -0700 (PDT) Received: by 10.42.28.9 with HTTP; Thu, 25 Jul 2013 02:58:25 -0700 (PDT) X-Originating-IP: [178.83.130.250] In-Reply-To: <20976.55523.670477.45248@linux-qknr.site> References: <2b828191fde71b2243f883e2dbb28d6d@hz6.de> <20130708200316.GG18285@phenom.ffwll.local> <20972.59257.635588.597578@linux-qknr.site> <20974.26726.659962.223064@linux-qknr.site> <20976.55523.670477.45248@linux-qknr.site> Date: Thu, 25 Jul 2013 11:58:25 +0200 X-Google-Sender-Auth: oRDun76yupFGwRW3lloLsb00bdc Message-ID: From: Daniel Vetter To: Egbert Eich X-Gm-Message-State: ALoCoQnSuzxzUWSQJWv1qDim3rCyiokXV6xukG+t4l3DUy34N3pV3/3Mb5XFGDx5TKGvq8+u5pI8 Cc: intel-gfx , Jan Niggemann Subject: Re: [Intel-gfx] i915 irq storm mitigation in 3.10 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jul 25, 2013 at 9:50 AM, Egbert Eich wrote: > > I applied this patch (but not the one you sent on Monday), recompiled > > and logged: > > uncompressed (8,2M) http://files.hz6.de/kern_20130724.log > > bz2 (288 KB) http://files.hz6.de/kern_20130724.log.bz2 > > These logs show clearly that we are seeing interrupts which > should be disabled. > Could it be that we we have either the status or enable bits > mixed up? Unfortunately the publically available docs for GEN4 > don't show the HOTPLUG_EN and HOTPLUG_STAT registers. > > Daniel, could you please help me out here? I've checked the docs again for gm45 and we seem to have the right values. But on early gen4 (i.e. i965g/gm) the Bspec has been wrong about these, so I wouldn't be surprised at all if they're wrong for the digital ports on gm45, too. Iirc we've already had a case like that, but there was no real conclusion (and atm I can't find the bug). Can you pls try the below patch (on top of Egbert's debug stuff)? Egbert I think your debug patch has fairly useful information for debugging the storm code in general, can you please submit a patch against drm-intel-nightly? Thanks, Daniel --- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 6caa748..2d4c884 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -1925,9 +1925,9 @@ #define PORT_HOTPLUG_STAT (dev_priv->info->display_mmio_offset + 0x61114) /* HDMI/DP bits are gen4+ */ -#define PORTB_HOTPLUG_LIVE_STATUS (1 << 29) +#define PORTD_HOTPLUG_LIVE_STATUS (1 << 29) #define PORTC_HOTPLUG_LIVE_STATUS (1 << 28) -#define PORTD_HOTPLUG_LIVE_STATUS (1 << 27) +#define PORTB_HOTPLUG_LIVE_STATUS (1 << 27) #define PORTD_HOTPLUG_INT_STATUS (3 << 21) #define PORTC_HOTPLUG_INT_STATUS (3 << 19) #define PORTB_HOTPLUG_INT_STATUS (3 << 17)