| Message ID | ZH7sr+Vs4zOQoouU@moroto (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv() | expand |
That was my bad, i could have sword i'd fixed that before the final rev. Thanks for fixing this. nit: below function applies to MTL only which at the moment is still force-probed, so not sure if the fixes tag is significant. Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com> On Tue, 2023-06-06 at 11:22 +0300, Dan Carpenter wrote: > This should return negative -EAGAIN instead of positive EAGAIN. > > Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c > index 579c0f5a1438..42218ae6ef13 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c > @@ -202,7 +202,7 @@ intel_gsc_uc_heci_cmd_submit_nonpriv(struct intel_gsc_uc *gsc, > if (++trials < 10) > goto retry; > else > - err = EAGAIN; > + err = -EAGAIN;
On Tue, Jun 06, 2023 at 06:07:19PM +0000, Teres Alexis, Alan Previn wrote: > That was my bad, i could have sword i'd fixed that before the final rev. Thanks for fixing this. > nit: below function applies to MTL only which at the moment is still force-probed, so not sure if the fixes tag is significant. > The Fixes tag is correct. It's definitely a bug fix. (I invented the Fixes tag so technically that makes me the worlds #1 expert on Fixes tags). regards, dan carpenter
On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > On Tue, Jun 06, 2023 at 06:07:19PM +0000, Teres Alexis, Alan Previn wrote: > > That was my bad, i could have sword i'd fixed that before the final rev. Thanks for fixing this. > > nit: below function applies to MTL only which at the moment is still force-probed, so not sure if the fixes tag is significant. > > > > The Fixes tag is correct. It's definitely a bug fix. > > (I invented the Fixes tag so technically that makes me the worlds #1 > expert on Fixes tags). > So sorry my bad.
Hi Dan, On Tue, Jun 06, 2023 at 11:22:07AM +0300, Dan Carpenter wrote: > This should return negative -EAGAIN instead of positive EAGAIN. > > Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi
Hi Dan, On Tue, Jun 06, 2023 at 11:22:07AM +0300, Dan Carpenter wrote: > This should return negative -EAGAIN instead of positive EAGAIN. > > Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> pushed to drm-intel-gt-next. Thanks, Andi
On Wed, Jun 07, 2023 at 06:44:54PM +0000, Teres Alexis, Alan Previn wrote: > On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > > On Tue, Jun 06, 2023 at 06:07:19PM +0000, Teres Alexis, Alan Previn wrote: > > > That was my bad, i could have sword i'd fixed that before the final rev. Thanks for fixing this. > > > nit: below function applies to MTL only which at the moment is still force-probed, so not sure if the fixes tag is significant. > > > > > > > The Fixes tag is correct. It's definitely a bug fix. > > > > (I invented the Fixes tag so technically that makes me the worlds #1 > > expert on Fixes tags). > > > So sorry my bad. LOL. Presumably the appology was intended sarcastically? Hopefully? Oh my goodness. ROFL... regards, dan carpenter
On Thu, 2023-06-08 at 11:37 +0300, Dan Carpenter wrote: > On Wed, Jun 07, 2023 at 06:44:54PM +0000, Teres Alexis, Alan Previn wrote: > > On Tue, 2023-06-06 at 21:32 +0300, Dan Carpenter wrote: > > > On Tue, Jun 06, 2023 at 06:07:19PM +0000, Teres Alexis, Alan Previn wrote: > > > > That was my bad, i could have sword i'd fixed that before the final rev. Thanks for fixing this. > > > > nit: below function applies to MTL only which at the moment is still force-probed, so not sure if the fixes tag is significant. > > > > > > > > > > The Fixes tag is correct. It's definitely a bug fix. > > > > > > (I invented the Fixes tag so technically that makes me the worlds #1 > > > expert on Fixes tags). > > > > > So sorry my bad. > > LOL. > > Presumably the appology was intended sarcastically? Hopefully? Oh my > goodness. ROFL... > lol - i'll take the 5th here - i should have phrased it differrently - my bad.
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c index 579c0f5a1438..42218ae6ef13 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c @@ -202,7 +202,7 @@ intel_gsc_uc_heci_cmd_submit_nonpriv(struct intel_gsc_uc *gsc, if (++trials < 10) goto retry; else - err = EAGAIN; + err = -EAGAIN; } } i915_gem_ww_ctx_fini(&ww);
This should return negative -EAGAIN instead of positive EAGAIN. Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)