mbox series

[PULL] drm-intel-fixes

Message ID ZgYaIVgjIs30mIvS@intel.com (mailing list archive)
State New
Headers show
Series [PULL] drm-intel-fixes | expand

Pull-request

https://anongit.freedesktop.org/git/drm/drm-intel tags/drm-intel-fixes-2024-03-28

Message

Rodrigo Vivi March 29, 2024, 1:32 a.m. UTC 
Hi Dave and Sima,

Here goes our first PR of this round.

Our CI is not working as I would expect:
https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html?

Well, at least it caught some build failures on runds 832 and 833.
But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with
all these patches here) didn't show up yet. So I have run manual validation
on my DG2+ADL here.

Everything looking good here, and it is yet -rc1. I'm confident
that we can move ahead with those while we work to get CI back.

Thanks,
Rodrigo

drm-intel-fixes-2024-03-28:

Core/GT Fixes:
- Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
- Update a MTL workaround (Tejas)
- Fix locking inversion in hwmon's sysfs (Janusz)
- Remove a bogus error message around PXP (Jose)
- Fix UAF on VMA (Janusz)
- Reset queue_priority_hint on parking (Chris)

Display Fixes:
- Remove duplicated audio enable/disable on SDVO and DP (Ville)
- Disable AuxCCS for Xe driver (Juha-Pekka)
- Revert init order of MIPI DSI (Ville)
- DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
- VRR related fixes (Ville)
- Fix a JSL eDP corruption (Jonathon)
- Fix the cursor physical dma address (Ville)
- BIOS VBT related fix (Ville)

Thanks,
Rodrigo.

The following changes since commit 4cece764965020c22cff7665b18a012006359095:

  Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)

are available in the Git repository at:

  https://anongit.freedesktop.org/git/drm/drm-intel tags/drm-intel-fixes-2024-03-28

for you to fetch changes up to 32e39bab59934bfd3f37097d4dd85ac5eb0fd549:

  drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode() (2024-03-28 12:16:17 -0400)

----------------------------------------------------------------
Core/GT Fixes:
- Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
- Update a MTL workaround (Tejas)
- Fix locking inversion in hwmon's sysfs (Janusz)
- Remove a bogus error message around PXP (Jose)
- Fix UAF on VMA (Janusz)
- Reset queue_priority_hint on parking (Chris)

Display Fixes:
- Remove duplicated audio enable/disable on SDVO and DP (Ville)
- Disable AuxCCS for Xe driver (Juha-Pekka)
- Revert init order of MIPI DSI (Ville)
- DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
- VRR related fixes (Ville)
- Fix a JSL eDP corruption (Jonathon)
- Fix the cursor physical dma address (Ville)
- BIOS VBT related fix (Ville)

----------------------------------------------------------------
Bhanuprakash Modem (2):
      drm/i915/drrs: Refactor CPU transcoder DRRS check
      drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status

Chris Wilson (1):
      drm/i915/gt: Reset queue_priority_hint on parking

Janusz Krzysztofik (2):
      drm/i915/hwmon: Fix locking inversion in sysfs getter
      drm/i915/vma: Fix UAF on destroy against retire race

Jonathon Hall (1):
      drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed()

Joonas Lahtinen (1):
      drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

José Roberto de Souza (1):
      drm/i915: Do not print 'pxp init failed with 0' when it succeed

Juha-Pekka Heikkila (1):
      drm/i915/display: Disable AuxCCS framebuffers if built for Xe

Tejas Upadhyay (1):
      drm/i915/mtl: Update workaround 14018575942

Ville Syrjälä (6):
      drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP
      drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly
      drm/i915/vrr: Generate VRR "safe window" for DSB
      drm/i915/dsb: Fix DSB vblank waits when using VRR
      drm/i915: Pre-populate the cursor physical dma address
      drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode()

 drivers/gpu/drm/i915/display/g4x_dp.c              |  2 -
 drivers/gpu/drm/i915/display/icl_dsi.c             |  3 +-
 drivers/gpu/drm/i915/display/intel_bios.c          | 46 +++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_cursor.c        |  4 +-
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c            | 12 +-----
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_drrs.c          | 14 ++++--
 drivers/gpu/drm/i915/display/intel_drrs.h          |  3 ++
 drivers/gpu/drm/i915/display/intel_dsb.c           | 14 ++++++
 drivers/gpu/drm/i915/display/intel_fb_pin.c        | 10 +++++
 drivers/gpu/drm/i915/display/intel_sdvo.c          |  4 --
 drivers/gpu/drm/i915/display/intel_vrr.c           |  7 +--
 drivers/gpu/drm/i915/display/skl_universal_plane.c |  3 ++
 drivers/gpu/drm/i915/gt/intel_engine_pm.c          |  3 --
 .../gpu/drm/i915/gt/intel_execlists_submission.c   |  3 ++
 drivers/gpu/drm/i915/gt/intel_workarounds.c        |  1 +
 drivers/gpu/drm/i915/i915_driver.c                 |  2 +-
 drivers/gpu/drm/i915/i915_hwmon.c                  | 37 ++++++++--------
 drivers/gpu/drm/i915/i915_memcpy.c                 |  2 +
 drivers/gpu/drm/i915/i915_reg.h                    |  2 +-
 drivers/gpu/drm/i915/i915_vma.c                    | 50 +++++++++++++++++++---
 22 files changed, 162 insertions(+), 63 deletions(-)

Comments

Musial, Ewelina March 29, 2024, 10:23 a.m. UTC | #1 
Hi Rodrigo,

When I opened dashboard early morning all results were available, so I don't think there was any issue during night.
It could be long reporting queue - reporting through AWS takes ages but this is not an issue with reporting, this is how AWS works.

Regards,
Ewelina

-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo Vivi
Sent: Friday, March 29, 2024 2:32 AM
To: Dave Airlie <airlied@gmail.com>; Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Tvrtko Ursulin <tursulin@ursulin.net>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Thomas Zimmermann <tzimmermann@suse.de>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Hellström <thomas.hellstrom@linux.intel.com>; Oded Gabbay <ogabbay@kernel.org>; De Marchi, Lucas <lucas.demarchi@intel.com>; dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; dim-tools@lists.freedesktop.org
Subject: [PULL] drm-intel-fixes

Hi Dave and Sima,

Here goes our first PR of this round.

Our CI is not working as I would expect:
https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html?

Well, at least it caught some build failures on runds 832 and 833.
But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with all these patches here) didn't show up yet. So I have run manual validation on my DG2+ADL here.

Everything looking good here, and it is yet -rc1. I'm confident that we can move ahead with those while we work to get CI back.

Thanks,
Rodrigo

drm-intel-fixes-2024-03-28:

Core/GT Fixes:
- Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
- Update a MTL workaround (Tejas)
- Fix locking inversion in hwmon's sysfs (Janusz)
- Remove a bogus error message around PXP (Jose)
- Fix UAF on VMA (Janusz)
- Reset queue_priority_hint on parking (Chris)

Display Fixes:
- Remove duplicated audio enable/disable on SDVO and DP (Ville)
- Disable AuxCCS for Xe driver (Juha-Pekka)
- Revert init order of MIPI DSI (Ville)
- DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
- VRR related fixes (Ville)
- Fix a JSL eDP corruption (Jonathon)
- Fix the cursor physical dma address (Ville)
- BIOS VBT related fix (Ville)

Thanks,
Rodrigo.

The following changes since commit 4cece764965020c22cff7665b18a012006359095:

  Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)

are available in the Git repository at:

  https://anongit.freedesktop.org/git/drm/drm-intel tags/drm-intel-fixes-2024-03-28

for you to fetch changes up to 32e39bab59934bfd3f37097d4dd85ac5eb0fd549:

  drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode() (2024-03-28 12:16:17 -0400)

----------------------------------------------------------------
Core/GT Fixes:
- Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
- Update a MTL workaround (Tejas)
- Fix locking inversion in hwmon's sysfs (Janusz)
- Remove a bogus error message around PXP (Jose)
- Fix UAF on VMA (Janusz)
- Reset queue_priority_hint on parking (Chris)

Display Fixes:
- Remove duplicated audio enable/disable on SDVO and DP (Ville)
- Disable AuxCCS for Xe driver (Juha-Pekka)
- Revert init order of MIPI DSI (Ville)
- DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
- VRR related fixes (Ville)
- Fix a JSL eDP corruption (Jonathon)
- Fix the cursor physical dma address (Ville)
- BIOS VBT related fix (Ville)

----------------------------------------------------------------
Bhanuprakash Modem (2):
      drm/i915/drrs: Refactor CPU transcoder DRRS check
      drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status

Chris Wilson (1):
      drm/i915/gt: Reset queue_priority_hint on parking

Janusz Krzysztofik (2):
      drm/i915/hwmon: Fix locking inversion in sysfs getter
      drm/i915/vma: Fix UAF on destroy against retire race

Jonathon Hall (1):
      drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed()

Joonas Lahtinen (1):
      drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c

José Roberto de Souza (1):
      drm/i915: Do not print 'pxp init failed with 0' when it succeed

Juha-Pekka Heikkila (1):
      drm/i915/display: Disable AuxCCS framebuffers if built for Xe

Tejas Upadhyay (1):
      drm/i915/mtl: Update workaround 14018575942

Ville Syrjälä (6):
      drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP
      drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly
      drm/i915/vrr: Generate VRR "safe window" for DSB
      drm/i915/dsb: Fix DSB vblank waits when using VRR
      drm/i915: Pre-populate the cursor physical dma address
      drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode()

 drivers/gpu/drm/i915/display/g4x_dp.c              |  2 -
 drivers/gpu/drm/i915/display/icl_dsi.c             |  3 +-
 drivers/gpu/drm/i915/display/intel_bios.c          | 46 +++++++++++++++++---
 drivers/gpu/drm/i915/display/intel_cursor.c        |  4 +-
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c            | 12 +-----
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_drrs.c          | 14 ++++--
 drivers/gpu/drm/i915/display/intel_drrs.h          |  3 ++
 drivers/gpu/drm/i915/display/intel_dsb.c           | 14 ++++++
 drivers/gpu/drm/i915/display/intel_fb_pin.c        | 10 +++++
 drivers/gpu/drm/i915/display/intel_sdvo.c          |  4 --
 drivers/gpu/drm/i915/display/intel_vrr.c           |  7 +--
 drivers/gpu/drm/i915/display/skl_universal_plane.c |  3 ++
 drivers/gpu/drm/i915/gt/intel_engine_pm.c          |  3 --
 .../gpu/drm/i915/gt/intel_execlists_submission.c   |  3 ++
 drivers/gpu/drm/i915/gt/intel_workarounds.c        |  1 +
 drivers/gpu/drm/i915/i915_driver.c                 |  2 +-
 drivers/gpu/drm/i915/i915_hwmon.c                  | 37 ++++++++--------
 drivers/gpu/drm/i915/i915_memcpy.c                 |  2 +
 drivers/gpu/drm/i915/i915_reg.h                    |  2 +-
 drivers/gpu/drm/i915/i915_vma.c                    | 50 +++++++++++++++++++---
 22 files changed, 162 insertions(+), 63 deletions(-)
Rodrigo Vivi March 29, 2024, 1:25 p.m. UTC | #2 
On Fri, Mar 29, 2024 at 06:23:54AM -0400, Musial, Ewelina wrote:
> Hi Rodrigo,
> 
> When I opened dashboard early morning all results were available, so I don't think there was any issue during night.
> It could be long reporting queue - reporting through AWS takes ages but this is not an issue with reporting, this is how AWS works.

I'm sorry for the noise. It was probably just a matter of time.

Everything looking good there.

Thanks,
Rodrigo.

> 
> Regards,
> Ewelina
> 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo Vivi
> Sent: Friday, March 29, 2024 2:32 AM
> To: Dave Airlie <airlied@gmail.com>; Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Tvrtko Ursulin <tursulin@ursulin.net>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; Thomas Zimmermann <tzimmermann@suse.de>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Hellström <thomas.hellstrom@linux.intel.com>; Oded Gabbay <ogabbay@kernel.org>; De Marchi, Lucas <lucas.demarchi@intel.com>; dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; dim-tools@lists.freedesktop.org
> Subject: [PULL] drm-intel-fixes
> 
> Hi Dave and Sima,
> 
> Here goes our first PR of this round.
> 
> Our CI is not working as I would expect:
> https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html?
> 
> Well, at least it caught some build failures on runds 832 and 833.
> But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with all these patches here) didn't show up yet. So I have run manual validation on my DG2+ADL here.
> 
> Everything looking good here, and it is yet -rc1. I'm confident that we can move ahead with those while we work to get CI back.
> 
> Thanks,
> Rodrigo
> 
> drm-intel-fixes-2024-03-28:
> 
> Core/GT Fixes:
> - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
> - Update a MTL workaround (Tejas)
> - Fix locking inversion in hwmon's sysfs (Janusz)
> - Remove a bogus error message around PXP (Jose)
> - Fix UAF on VMA (Janusz)
> - Reset queue_priority_hint on parking (Chris)
> 
> Display Fixes:
> - Remove duplicated audio enable/disable on SDVO and DP (Ville)
> - Disable AuxCCS for Xe driver (Juha-Pekka)
> - Revert init order of MIPI DSI (Ville)
> - DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
> - VRR related fixes (Ville)
> - Fix a JSL eDP corruption (Jonathon)
> - Fix the cursor physical dma address (Ville)
> - BIOS VBT related fix (Ville)
> 
> Thanks,
> Rodrigo.
> 
> The following changes since commit 4cece764965020c22cff7665b18a012006359095:
> 
>   Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
> 
> are available in the Git repository at:
> 
>   https://anongit.freedesktop.org/git/drm/drm-intel tags/drm-intel-fixes-2024-03-28
> 
> for you to fetch changes up to 32e39bab59934bfd3f37097d4dd85ac5eb0fd549:
> 
>   drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode() (2024-03-28 12:16:17 -0400)
> 
> ----------------------------------------------------------------
> Core/GT Fixes:
> - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas)
> - Update a MTL workaround (Tejas)
> - Fix locking inversion in hwmon's sysfs (Janusz)
> - Remove a bogus error message around PXP (Jose)
> - Fix UAF on VMA (Janusz)
> - Reset queue_priority_hint on parking (Chris)
> 
> Display Fixes:
> - Remove duplicated audio enable/disable on SDVO and DP (Ville)
> - Disable AuxCCS for Xe driver (Juha-Pekka)
> - Revert init order of MIPI DSI (Ville)
> - DRRS debugfs fix with an extra refactor patch (Bhanuprakash)
> - VRR related fixes (Ville)
> - Fix a JSL eDP corruption (Jonathon)
> - Fix the cursor physical dma address (Ville)
> - BIOS VBT related fix (Ville)
> 
> ----------------------------------------------------------------
> Bhanuprakash Modem (2):
>       drm/i915/drrs: Refactor CPU transcoder DRRS check
>       drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status
> 
> Chris Wilson (1):
>       drm/i915/gt: Reset queue_priority_hint on parking
> 
> Janusz Krzysztofik (2):
>       drm/i915/hwmon: Fix locking inversion in sysfs getter
>       drm/i915/vma: Fix UAF on destroy against retire race
> 
> Jonathon Hall (1):
>       drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed()
> 
> Joonas Lahtinen (1):
>       drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c
> 
> José Roberto de Souza (1):
>       drm/i915: Do not print 'pxp init failed with 0' when it succeed
> 
> Juha-Pekka Heikkila (1):
>       drm/i915/display: Disable AuxCCS framebuffers if built for Xe
> 
> Tejas Upadhyay (1):
>       drm/i915/mtl: Update workaround 14018575942
> 
> Ville Syrjälä (6):
>       drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP
>       drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly
>       drm/i915/vrr: Generate VRR "safe window" for DSB
>       drm/i915/dsb: Fix DSB vblank waits when using VRR
>       drm/i915: Pre-populate the cursor physical dma address
>       drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode()
> 
>  drivers/gpu/drm/i915/display/g4x_dp.c              |  2 -
>  drivers/gpu/drm/i915/display/icl_dsi.c             |  3 +-
>  drivers/gpu/drm/i915/display/intel_bios.c          | 46 +++++++++++++++++---
>  drivers/gpu/drm/i915/display/intel_cursor.c        |  4 +-
>  drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
>  drivers/gpu/drm/i915/display/intel_dp.c            | 12 +-----
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  2 +-
>  drivers/gpu/drm/i915/display/intel_drrs.c          | 14 ++++--
>  drivers/gpu/drm/i915/display/intel_drrs.h          |  3 ++
>  drivers/gpu/drm/i915/display/intel_dsb.c           | 14 ++++++
>  drivers/gpu/drm/i915/display/intel_fb_pin.c        | 10 +++++
>  drivers/gpu/drm/i915/display/intel_sdvo.c          |  4 --
>  drivers/gpu/drm/i915/display/intel_vrr.c           |  7 +--
>  drivers/gpu/drm/i915/display/skl_universal_plane.c |  3 ++
>  drivers/gpu/drm/i915/gt/intel_engine_pm.c          |  3 --
>  .../gpu/drm/i915/gt/intel_execlists_submission.c   |  3 ++
>  drivers/gpu/drm/i915/gt/intel_workarounds.c        |  1 +
>  drivers/gpu/drm/i915/i915_driver.c                 |  2 +-
>  drivers/gpu/drm/i915/i915_hwmon.c                  | 37 ++++++++--------
>  drivers/gpu/drm/i915/i915_memcpy.c                 |  2 +
>  drivers/gpu/drm/i915/i915_reg.h                    |  2 +-
>  drivers/gpu/drm/i915/i915_vma.c                    | 50 +++++++++++++++++++---
>  22 files changed, 162 insertions(+), 63 deletions(-)