diff mbox series

[5/6] drm: include drm_file.h from drm_syncobj.h

Message ID d2a557849f16abdb0bf411e21b5d743a59b03ea9.1545915059.git.jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: drmP.h include removal w/ drm prep work | expand

Commit Message

Jani Nikula Dec. 27, 2018, 12:56 p.m. UTC 
Make it easier to drop drmP.h includes. Switch from "" to <> includes
while at it.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 include/drm/drm_syncobj.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Daniel Vetter Dec. 27, 2018, 4:08 p.m. UTC | #1 
On Thu, Dec 27, 2018 at 02:56:40PM +0200, Jani Nikula wrote:
> Make it easier to drop drmP.h includes. Switch from "" to <> includes
> while at it.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  include/drm/drm_syncobj.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_syncobj.h b/include/drm/drm_syncobj.h
> index 7c6ed845c70d..93884da3f9fe 100644
> --- a/include/drm/drm_syncobj.h
> +++ b/include/drm/drm_syncobj.h
> @@ -26,7 +26,9 @@
>  #ifndef __DRM_SYNCOBJ_H__
>  #define __DRM_SYNCOBJ_H__
>  
> -#include "linux/dma-fence.h"
> +#include <linux/dma-fence.h>
> +
> +#include <drm/drm_file.h>

I think you need only a

struct drm_file;

pre-decl instead of the full include. With that:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>  
>  /**
>   * struct drm_syncobj - sync object.
> -- 
> 2.11.0
>
diff mbox series

Patch

diff --git a/include/drm/drm_syncobj.h b/include/drm/drm_syncobj.h
index 7c6ed845c70d..93884da3f9fe 100644
--- a/include/drm/drm_syncobj.h
+++ b/include/drm/drm_syncobj.h
@@ -26,7 +26,9 @@ 
 #ifndef __DRM_SYNCOBJ_H__
 #define __DRM_SYNCOBJ_H__
 
-#include "linux/dma-fence.h"
+#include <linux/dma-fence.h>
+
+#include <drm/drm_file.h>
 
 /**
  * struct drm_syncobj - sync object.