diff mbox series

[08/15] drm/i915/gt/uc: drop unused but set variable sseu

Message ID d542f25bffd5a50ff621bee93415a972c7768a2a.1685119007.git.jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: re-enable -Wunused-but-set-variable | expand

Commit Message

Jani Nikula May 26, 2023, 4:38 p.m. UTC 
Prepare for re-enabling -Wunused-but-set-variable.

Apparently sseu is leftover from commit 9a92732f040a ("drm/i915/gt: Add
general DSS steering iterator to intel_gt_mcr").

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andi Shyti May 26, 2023, 5:51 p.m. UTC | #1 
Hi Jani,

On Fri, May 26, 2023 at 07:38:01PM +0300, Jani Nikula wrote:
> Prepare for re-enabling -Wunused-but-set-variable.
> 
> Apparently sseu is leftover from commit 9a92732f040a ("drm/i915/gt: Add
> general DSS steering iterator to intel_gt_mcr").
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> index 0ff864da92df..331cec07c125 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> @@ -301,7 +301,6 @@ guc_capture_alloc_steered_lists(struct intel_guc *guc,
>  	const struct __guc_mmio_reg_descr_group *list;
>  	struct __guc_mmio_reg_descr_group *extlists;
>  	struct __guc_mmio_reg_descr *extarray;
> -	struct sseu_dev_info *sseu;
>  	bool has_xehpg_extregs;
>  
>  	/* steered registers currently only exist for the render-class */
> @@ -318,7 +317,6 @@ guc_capture_alloc_steered_lists(struct intel_guc *guc,
>  	if (has_xehpg_extregs)
>  		num_steer_regs += ARRAY_SIZE(xehpg_extregs);
>  
> -	sseu = &gt->info.sseu;

leftovers...

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> 

Thanks,
Andi

>  	for_each_ss_steering(iter, gt, slice, subslice)
>  		num_tot_regs += num_steer_regs;
>  
> -- 
> 2.39.2
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
index 0ff864da92df..331cec07c125 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
@@ -301,7 +301,6 @@  guc_capture_alloc_steered_lists(struct intel_guc *guc,
 	const struct __guc_mmio_reg_descr_group *list;
 	struct __guc_mmio_reg_descr_group *extlists;
 	struct __guc_mmio_reg_descr *extarray;
-	struct sseu_dev_info *sseu;
 	bool has_xehpg_extregs;
 
 	/* steered registers currently only exist for the render-class */
@@ -318,7 +317,6 @@  guc_capture_alloc_steered_lists(struct intel_guc *guc,
 	if (has_xehpg_extregs)
 		num_steer_regs += ARRAY_SIZE(xehpg_extregs);
 
-	sseu = &gt->info.sseu;
 	for_each_ss_steering(iter, gt, slice, subslice)
 		num_tot_regs += num_steer_regs;