| Message ID | f53f8a9d04b39a6843f19fe3069d1be7a9713aae.1652113087.git.mchehab@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Let userspace know when snd-hda-intel needs i915 | expand |
On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that depends on > i915 driver. > > Ensure that a proper reference between the snd-hda driver needing > such binding is shown at /proc/modules, in order to allow userspace > to know about such binding. > > Reviewed-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> > --- > > See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mchehab@kernel.org/ > > sound/hda/hdac_component.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c > index bb37e7e0bd79..7789873ddf47 100644 > --- a/sound/hda/hdac_component.c > +++ b/sound/hda/hdac_component.c > @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) > } > > /* pin the module to avoid dynamic unbinding, but only if given */ > - if (!try_module_get(acomp->ops->owner)) { > + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { I'm still a bit confused why snd-hda does this and why this wasn't put into component.c, but that's kinda a pre-existing issue and I guess could be fixed later on. It really shouldn't be anything specific to snd-hda here. Anyway I scrolled through the series, it makes a lot more sense than the intial hack to me, so on the series: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> But maybe don't count that as real review :-) Cheers, Daniel
diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index bb37e7e0bd79..7789873ddf47 100644 --- a/sound/hda/hdac_component.c +++ b/sound/hda/hdac_component.c @@ -199,7 +199,7 @@ static int hdac_component_master_bind(struct device *dev) } /* pin the module to avoid dynamic unbinding, but only if given */ - if (!try_module_get(acomp->ops->owner)) { + if (!try_module_get_owner(acomp->ops->owner, dev->driver->owner)) { ret = -ENODEV; goto out_unbind; }