[RFC,2/2] drm/i915/display: try out the new crtc iterators

Commit Message

Jani Nikula Sept. 19, 2024, 8:14 p.m. UTC

Random conversions here and there.

Cc: Ankit Nautiyal <[e-mail]>
Cc: Ville Syrjälä <[e-mail]>
Signed-off-by: Jani Nikula <[e-mail]>
---
 drivers/gpu/drm/i915/display/intel_ddi.c     | 17 ++++++++++++-----
 drivers/gpu/drm/i915/display/intel_display.c | 16 ++++++++++++----
 2 files changed, 24 insertions(+), 9 deletions(-)

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 85e519a21542..b822b28df213 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -41,6 +41,7 @@ 
 #include "intel_combo_phy_regs.h"
 #include "intel_connector.h"
 #include "intel_crtc.h"
+#include "intel_crtc_iter.h"
 #include "intel_cx0_phy.h"
 #include "intel_cx0_phy_regs.h"
 #include "intel_ddi.h"
@@ -3117,21 +3118,24 @@  static void intel_ddi_post_disable_hdmi_or_sst(struct intel_atomic_state *state,
 {
 	struct intel_display *display = to_intel_display(encoder);
 	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+	struct intel_crtc_iter iter;
 	struct intel_crtc *pipe_crtc;
-	int i;
 
-	for_each_pipe_crtc_modeset_disable(display, pipe_crtc, old_crtc_state, i) {
+	intel_crtc_iter_begin_modeset_disable(display, &iter, old_crtc_state);
+	intel_crtc_iter_for_each(pipe_crtc, &iter) {
 		const struct intel_crtc_state *old_pipe_crtc_state =
 			intel_atomic_get_old_crtc_state(state, pipe_crtc);
 
 		intel_crtc_vblank_off(old_pipe_crtc_state);
 	}
+	intel_crtc_iter_end(&iter);
 
 	intel_disable_transcoder(old_crtc_state);
 
 	intel_ddi_disable_transcoder_func(old_crtc_state);
 
-	for_each_pipe_crtc_modeset_disable(display, pipe_crtc, old_crtc_state, i) {
+	intel_crtc_iter_begin_modeset_disable(display, &iter, old_crtc_state);
+	intel_crtc_iter_for_each(pipe_crtc, &iter) {
 		const struct intel_crtc_state *old_pipe_crtc_state =
 			intel_atomic_get_old_crtc_state(state, pipe_crtc);
 
@@ -3142,6 +3146,7 @@  static void intel_ddi_post_disable_hdmi_or_sst(struct intel_atomic_state *state,
 		else
 			ilk_pfit_disable(old_pipe_crtc_state);
 	}
+	intel_crtc_iter_end(&iter);
 }
 
 static void intel_ddi_post_disable(struct intel_atomic_state *state,
@@ -3383,8 +3388,8 @@  static void intel_enable_ddi(struct intel_atomic_state *state,
 			     const struct drm_connector_state *conn_state)
 {
 	struct intel_display *display = to_intel_display(encoder);
+	struct intel_crtc_iter iter;
 	struct intel_crtc *pipe_crtc;
-	int i;
 
 	intel_ddi_enable_transcoder_func(encoder, crtc_state);
 
@@ -3395,12 +3400,14 @@  static void intel_enable_ddi(struct intel_atomic_state *state,
 
 	intel_ddi_wait_for_fec_status(encoder, crtc_state, true);
 
-	for_each_pipe_crtc_modeset_enable(display, pipe_crtc, crtc_state, i) {
+	intel_crtc_iter_begin_modeset_enable(display, &iter, crtc_state);
+	intel_crtc_iter_for_each(pipe_crtc, &iter) {
 		const struct intel_crtc_state *pipe_crtc_state =
 			intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
 		intel_crtc_vblank_on(pipe_crtc_state);
 	}
+	intel_crtc_iter_end(&iter);
 
 	if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
 		intel_enable_ddi_hdmi(state, encoder, crtc_state, conn_state);
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 7136c80ac8cc..4aedc7e49fe1 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -65,6 +65,7 @@ 
 #include "intel_color.h"
 #include "intel_crt.h"
 #include "intel_crtc.h"
+#include "intel_crtc_iter.h"
 #include "intel_crtc_state_dump.h"
 #include "intel_cursor_regs.h"
 #include "intel_cx0_phy.h"
@@ -3583,6 +3584,8 @@  static bool transcoder_ddi_func_is_enabled(struct drm_i915_private *dev_priv,
 static void enabled_joiner_pipes(struct drm_i915_private *dev_priv,
 				 u8 *primary_pipes, u8 *secondary_pipes)
 {
+	struct intel_display *display = &dev_priv->display;
+	struct intel_crtc_iter iter;
 	struct intel_crtc *crtc;
 
 	*primary_pipes = 0;
@@ -3591,8 +3594,8 @@  static void enabled_joiner_pipes(struct drm_i915_private *dev_priv,
 	if (!HAS_BIGJOINER(dev_priv))
 		return;
 
-	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc,
-					 joiner_pipes(dev_priv)) {
+	intel_crtc_iter_begin_pipe_mask(display, &iter, joiner_pipes(dev_priv));
+	intel_crtc_iter_for_each(crtc, &iter) {
 		enum intel_display_power_domain power_domain;
 		enum pipe pipe = crtc->pipe;
 		intel_wakeref_t wakeref;
@@ -3623,6 +3626,7 @@  static void enabled_joiner_pipes(struct drm_i915_private *dev_priv,
 				*secondary_pipes |= BIT(pipe);
 		}
 	}
+	intel_crtc_iter_end(&iter);
 
 	/* Joiner pipes should always be consecutive primary and secondary */
 	drm_WARN(&dev_priv->drm, *secondary_pipes != *primary_pipes << 1,
@@ -6911,22 +6915,26 @@  static void commit_pipe_post_planes(struct intel_atomic_state *state,
 static void intel_enable_crtc(struct intel_atomic_state *state,
 			      struct intel_crtc *crtc)
 {
+	struct intel_display *display = to_intel_display(state);
 	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	const struct intel_crtc_state *new_crtc_state =
 		intel_atomic_get_new_crtc_state(state, crtc);
+	struct intel_crtc_iter iter;
 	struct intel_crtc *pipe_crtc;
 
 	if (!intel_crtc_needs_modeset(new_crtc_state))
 		return;
 
-	for_each_intel_crtc_in_pipe_mask_reverse(&dev_priv->drm, pipe_crtc,
-						 intel_crtc_joined_pipe_mask(new_crtc_state)) {
+	intel_crtc_iter_begin_pipe_mask_reverse(display, &iter,
+						intel_crtc_joined_pipe_mask(new_crtc_state));
+	intel_crtc_iter_for_each(pipe_crtc, &iter) {
 		const struct intel_crtc_state *pipe_crtc_state =
 			intel_atomic_get_new_crtc_state(state, pipe_crtc);
 
 		/* VRR will be enable later, if required */
 		intel_crtc_update_active_timings(pipe_crtc_state, false);
 	}
+	intel_crtc_iter_end(&iter);
 
 	dev_priv->display.funcs.display->crtc_enable(state, crtc);