From patchwork Tue Nov 28 16:41:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Wajdeczko X-Patchwork-Id: 10080765 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 80C6560234 for ; Tue, 28 Nov 2017 16:41:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 836F829485 for ; Tue, 28 Nov 2017 16:41:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 788CA294C6; Tue, 28 Nov 2017 16:41:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2C79F29485 for ; Tue, 28 Nov 2017 16:41:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09DF36E272; Tue, 28 Nov 2017 16:41:19 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B93416E272 for ; Tue, 28 Nov 2017 16:41:17 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2017 08:41:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.44,468,1505804400"; d="scan'208"; a="1249536825" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 28 Nov 2017 08:41:14 -0800 Received: from mwajdecz-mobl1.ger.corp.intel.com (mwajdecz-mobl1.ger.corp.intel.com [172.28.174.150]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id vASGfD4k003809; Tue, 28 Nov 2017 16:41:13 GMT To: Patchwork , intel-gfx@lists.freedesktop.org References: <20171128154216.43016-1-michal.wajdeczko@intel.com> <20171128160727.18891.81444@emeril.freedesktop.org> Date: Tue, 28 Nov 2017 17:41:13 +0100 MIME-Version: 1.0 From: "Michal Wajdeczko" Message-ID: In-Reply-To: <20171128160727.18891.81444@emeril.freedesktop.org> User-Agent: Opera Mail/1.0 (Win32) Subject: Re: [Intel-gfx] =?utf-8?q?=E2=9C=97_Fi=2ECI=2EBAT=3A_failure_for_drm/?= =?utf-8?q?i915=3A_Unifying_debugfs_return_codes_for_unsupported_features?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 28 Nov 2017 17:07:27 +0100, Patchwork wrote: > == Series Details == > > Series: drm/i915: Unifying debugfs return codes for unsupported features > URL : https://patchwork.freedesktop.org/series/34552/ > State : failure > > == Summary == > > Series 34552v1 drm/i915: Unifying debugfs return codes for unsupported > features > https://patchwork.freedesktop.org/api/1.0/series/34552/revisions/1/mbox/ > > Test kms_frontbuffer_tracking: > Subgroup basic: > skip -> FAIL (fi-elk-e7500) > pass -> FAIL (fi-byt-j1900) > pass -> FAIL (fi-byt-n2820) > pass -> FAIL (fi-bsw-n3050) > It looks that "igt/kms_frontbuffer_tracking: Keep the debugfs dir around" introduced igt_assert that fires when we try to return -ENODEV. I think we can replace it with proper handling (see __igt_debugfs_read) diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c index a068c8a..50019d1 100644 --- a/tests/kms_frontbuffer_tracking.c +++ b/tests/kms_frontbuffer_tracking.c @@ -783,7 +783,8 @@ static bool set_mode_for_params(struct modeset_params *params) static void __debugfs_read(const char *param, char *buf, int len) { len = igt_sysfs_read(drm.debugfs, param, buf, len - 1); - igt_assert(len > 0); + if (len < 0) + len = 0; buf[len] = '\0'; }