[v2,0/6] x86/sgx: A collection of tests and fixes

Message

Jarkko Sakkinen Aug. 31, 2022, 5:38 p.m. UTC

Haitao Huang (2):
  x86/sgx: Handle VA page allocation failure for EAUG on PF.
  selftests/sgx: retry the ioctls returned with EAGAIN

Jarkko Sakkinen (2):
  x86/sgx: Do not consider unsanitized pages an error
  selftests/sgx: Add a bpftrace script for tracking allocation errors

Kristen Carlson Accardi (1):
  selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning

Vijay Dhanraj (1):
  selftests/sgx: Add SGX selftest augment_via_eaccept_long

 arch/x86/kernel/cpu/sgx/encl.c             |   5 +-
 arch/x86/kernel/cpu/sgx/main.c             |  42 ++++-
 tools/testing/selftests/sgx/alloc-error.bt |   9 +
 tools/testing/selftests/sgx/load.c         |   5 +-
 tools/testing/selftests/sgx/main.c         | 185 ++++++++++++++++++---
 tools/testing/selftests/sgx/main.h         |   3 +-
 tools/testing/selftests/sgx/sigstruct.c    |   6 +
 7 files changed, 218 insertions(+), 37 deletions(-)
 create mode 100644 tools/testing/selftests/sgx/alloc-error.bt

Comments

Dave Hansen Aug. 31, 2022, 5:43 p.m. UTC | #1

Jarkko,

What is your expectations of this series?  There's nothing in the cover
letter.

Do you think all of this is urgent material that needs to go to Linus
for 6.0?  Or is it all 6.1 material?

Jarkko Sakkinen Aug. 31, 2022, 6:11 p.m. UTC | #2

On Wed, Aug 31, 2022 at 10:43:05AM -0700, Dave Hansen wrote:
> Jarkko,
> 
> What is your expectations of this series?  There's nothing in the cover
> letter.
> 
> Do you think all of this is urgent material that needs to go to Linus
> for 6.0?  Or is it all 6.1 material?

Hmm... Let me think.

I would pick exactly 2/6 and 3/6 and postpone rest for 6.1.

2/6 is IMHO critical fix and 3/6 is fix for a commit that
is part of 6.0.

BR, Jarkko

Dave Hansen Aug. 31, 2022, 6:24 p.m. UTC | #3

On 8/31/22 11:11, Jarkko Sakkinen wrote:
> On Wed, Aug 31, 2022 at 10:43:05AM -0700, Dave Hansen wrote:
>> Jarkko,
>>
>> What is your expectations of this series?  There's nothing in the cover
>> letter.
>>
>> Do you think all of this is urgent material that needs to go to Linus
>> for 6.0?  Or is it all 6.1 material?
> Hmm... Let me think.
> 
> I would pick exactly 2/6 and 3/6 and postpone rest for 6.1.
> 
> 2/6 is IMHO critical fix and 3/6 is fix for a commit that
> is part of 6.0.

That's really great context, thanks!  Next time, could you please
include that in your cover letter(s) and split the patches up between
urgent non-urgent bits?

Jarkko Sakkinen Aug. 31, 2022, 6:47 p.m. UTC | #4

On Wed, Aug 31, 2022 at 11:24:52AM -0700, Dave Hansen wrote:
> On 8/31/22 11:11, Jarkko Sakkinen wrote:
> > On Wed, Aug 31, 2022 at 10:43:05AM -0700, Dave Hansen wrote:
> >> Jarkko,
> >>
> >> What is your expectations of this series?  There's nothing in the cover
> >> letter.
> >>
> >> Do you think all of this is urgent material that needs to go to Linus
> >> for 6.0?  Or is it all 6.1 material?
> > Hmm... Let me think.
> > 
> > I would pick exactly 2/6 and 3/6 and postpone rest for 6.1.
> > 
> > 2/6 is IMHO critical fix and 3/6 is fix for a commit that
> > is part of 6.0.
> 
> That's really great context, thanks!  Next time, could you please
> include that in your cover letter(s) and split the patches up between
> urgent non-urgent bits?

I can, no problem.

BR, Jarkko